Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes a couple of changes to improve the experience of passing hints to guest programs via the CLI.
debug_memory_rangesfromsrc/e2e.rsbecause it fails when hints are non-empty.--structured-hintsoption forbin/e2e.rs. This parses a sequence ofu32s in decimal notation from a file and serializes them so that they can be consumed by the guest; i.e, a file containing the valuesN a1 a2 .. aNwill produce hints such thatlet input: &ArchivedVec<u32> = ceno_rt::read();in the guest will result ininput = [a1, a2.. aN]. This is easier to use than the existing--hintsoption (now renamed to--raw--hints) which requires the user to serialize the input correctly on their own;I think in the long-term more general solutions are required to increase compatibility of guest programs with
bin/e2e.rs, but this PR is an ok compromise for my day-to-day.