Run tests against local server by default#248
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the test configuration to run against a local server by default instead of the staging server, making local development more convenient while maintaining staging server usage in CI/CD.
Changes:
- Modified test configuration to default to localhost:9001 when API_URL is not set
- Added default value for API secret to support local testing
- Configured CI/CD workflow to explicitly use staging server
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/java/seatsio/SeatsioClientTest.java | Simplified environment variable handling using getOrDefault() and removed unused import. Now defaults to localhost:9001 and provides a default API secret for local development. |
| .github/workflows/build.yml | Explicitly sets API_URL to staging server to maintain CI/CD behavior despite the new local defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
schaloner
approved these changes
Jan 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.