Fixes 1156 (Issue with scalar literals in code coverage)#1157
Closed
DeveloperRob wants to merge 1 commit intosebastianbergmann:mainfrom
Closed
Fixes 1156 (Issue with scalar literals in code coverage)#1157DeveloperRob wants to merge 1 commit intosebastianbergmann:mainfrom
DeveloperRob wants to merge 1 commit intosebastianbergmann:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1157 +/- ##
============================================
+ Coverage 82.31% 82.32% +0.01%
- Complexity 1562 1565 +3
============================================
Files 114 114
Lines 5315 5319 +4
============================================
+ Hits 4375 4379 +4
Misses 940 940 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it as I think 3203ed6 is a "cleaner" solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1156 by updating ExecutableLinesFindingVisitor.php so that where an expression is solely a string literal, float literal, integer literal (
PHPParser\Node\Scalar) ornull/true/false(PHPParser\Node\Expr\ConstFetch); the node is ignored / not marked as executable.