Add CBOR implementation following the ASN.1 implementation paradigm (by Copilot)#4916
Merged
polybassa merged 17 commits intosecdev:masterfrom Mar 17, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4916 +/- ##
==========================================
+ Coverage 80.27% 80.30% +0.02%
==========================================
Files 375 379 +4
Lines 92480 93102 +622
==========================================
+ Hits 74242 74769 +527
- Misses 18238 18333 +95
🚀 New features to boost your workflow:
|
Member
|
Can we like, still ask him to do changes? |
|
Absolutely. What changes do you have in mind? |
Co-authored-by: polybassa <1676055+polybassa@users.noreply.github.com> Address code review comments: improve error messages and implement proper half-float decoding Co-authored-by: polybassa <1676055+polybassa@users.noreply.github.com> Add cbor2 interoperability tests (cbor2 used ONLY in tests) Co-authored-by: polybassa <1676055+polybassa@users.noreply.github.com> Document cbor2 as test-only dependency in test file header Co-authored-by: polybassa <1676055+polybassa@users.noreply.github.com> Add CBOR documentation to advanced_usage.rst following ASN.1 pattern Co-authored-by: polybassa <1676055+polybassa@users.noreply.github.com> Add cbor2 to tox.ini testenv deps for CBOR interoperability tests Co-authored-by: polybassa <1676055+polybassa@users.noreply.github.com>
…on; remove trailing whitespaces.
Co-authored-by: polybassa <1676055+polybassa@users.noreply.github.com>
… file opens Co-authored-by: polybassa <1676055+polybassa@users.noreply.github.com>
Co-authored-by: polybassa <1676055+polybassa@users.noreply.github.com>
…re generation Co-authored-by: polybassa <1676055+polybassa@users.noreply.github.com>
…ertions Co-authored-by: polybassa <1676055+polybassa@users.noreply.github.com>
polybassa
force-pushed
the
implement-cbor-parser-asn1
branch
from
2d1069d to
65646ea
Compare
Contributor
Author
|
@gpotter2 I've modified the docs a little. I will merge this PR and go forward with CBOR Fields and explore a generic codec implementation. |
added 6 commits
March 17, 2026 21:30
gpotter2
reviewed
Mar 17, 2026
| cryptography | ||
| coverage[toml] | ||
| python-can | ||
| cbor2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some experiments with Github Copilot for a CBOR implementation. I manually reviewed the implementation.