fix(jellyfin-scanner): use service instance for 4k availability detection #2227
+285
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallenbagel
force-pushed
the
fallenbagel/fix/jellyfin-4k-detection
branch
from
f2c0f88 to
d02906d
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
…tion when 4k services are enabled, jellyfin scanner will now check which arr instance has the file todetermine availability tier instead of relying solely on resolution detection. This should fix theincorrecta availability status when a 4k request results in a lower resolution file. Fallbacks tooriginal resolution based detection when media not found. fix #1744
fallenbagel
force-pushed
the
fallenbagel/fix/jellyfin-4k-detection
branch
from
d02906d to
09233a3
Compare
github-actions
bot
removed
the
merge conflict
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Jellyfin scanner where 4K requests that resulted in lower resolution files (e.g., 1080p while awaiting 4K releases) were incorrectly marked as available to all users. The fix introduces service-based availability detection by querying Radarr/Sonarr instances to determine which tier owns each file, with fallback to resolution-based detection for manually added media.
- Adds
ServiceAvailabilityCheckerclass to query Radarr/Sonarr instances and determine availability based on service instance rather than file resolution - Integrates service-based detection into Jellyfin scanner for both movies and TV shows with caching support
- Removes outdated TODO comment explaining the exact issue this PR addresses
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 17 comments.
| File | Description |
|---|---|
| server/lib/scanners/serviceAvailabilityChecker.ts | New module implementing service-based availability checking with caching for movies and TV shows |
| server/lib/scanners/jellyfin/index.ts | Integrates serviceAvailabilityChecker for 4K detection, adds cache clearing on scan start, removes resolution-based detection TODO |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a 4K request results in a lower resolution file (e.g., 1080p while waiting for a 4K release), the Jellyfin scanner previously used resolution to determine availability, incorrectly marking these files as
Available. This caused non-4K users to see phantom availability for content only in the 4K library.This PR adds
ServiceAvailabilityCheckerthat queries Radarr/Sonarr instances to determine which tier has the file based on which instance it came from, not resolution. Falls back to resolution-based detection for manually added media. No impact on users without 4K instances configured.How Has This Been Tested?
This has not been tested by me.
Screenshots / Logs (if applicable)
Checklist:
pnpm buildpnpm i18n:extract