Improve SeiDB replay&restart time by 2x #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
131
to
137
|
|
||
| func (t *Tree) WaitToCompleteAsyncWrite() { | ||
| close(t.pendingChanges) | ||
| t.pendingWg.Wait() | ||
| t.pendingChanges = nil | ||
| } | ||
|
|
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
philipsu522
approved these changes
Jan 7, 2025
blindchaser
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Add parallelization for replaying changelog on all modules during restart. Reduced restart/replay time by 2x, 15 minutes -> 7 minutes
Testing performed to validate your change
Before this change:
After this change: