Skip to content

feat(planner): re-apply config.toml as part of buildNodeUpdatePlan #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdchatham wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(planner): re-apply config.toml as part of buildNodeUpdatePlan #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d4dc7d
feat(planner): re-apply config.toml as part of buildNodeUpdatePlan
bdchatham May 30, 2026
43a0018
fix(planner): nil-guard BuildConfigIntent + pin init Incremental=false
bdchatham May 30, 2026
b656d5e
refactor(planner): per-mode day-2 plans + config-patch task
bdchatham May 31, 2026
4b91ac6
chore(planner): drop "day 2" terminology + comment sweep
bdchatham May 31, 2026
819ad34
test(planner,task): close three coverage gaps before final review
bdchatham May 31, 2026
f03714f
chore(planner): hoist setNodeUpdateCondition out of assembleUpdatePlan
bdchatham May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions internal/planner/archive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@ import (
"strconv"

seiconfig "github.com/sei-protocol/sei-config"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

seiv1alpha1 "github.com/sei-protocol/sei-k8s-controller/api/v1alpha1"
"github.com/sei-protocol/sei-k8s-controller/internal/task"
)

type archiveNodePlanner struct {
Expand All @@ -26,12 +28,35 @@ func (p *archiveNodePlanner) Validate(node *seiv1alpha1.SeiNode) error {

func (p *archiveNodePlanner) BuildPlan(node *seiv1alpha1.SeiNode) (*seiv1alpha1.TaskPlan, error) {
if node.Status.Phase == seiv1alpha1.PhaseRunning {
return buildRunningPlan(node)
return p.buildRunningPlan(node)
}
return buildBasePlan(node, node.Spec.Peers, nil, &seiconfig.ConfigIntent{
intent := &seiconfig.ConfigIntent{
Mode: seiconfig.ModeArchive,
Overrides: mergeOverrides(mergeOverrides(commonOverrides(node), p.controllerOverrides(node)), node.Spec.Overrides),
})
}
return buildBasePlan(node, node.Spec.Peers, nil, intent)
}

// buildRunningPlan returns the update plan for a Running archive node.
// Same shape as full nodes (no extra validation gates).
func (p *archiveNodePlanner) buildRunningPlan(node *seiv1alpha1.SeiNode) (*seiv1alpha1.TaskPlan, error) {
if imageDrifted(node) {
setNodeUpdateCondition(node, metav1.ConditionTrue, "UpdateStarted", imageDriftMessage(node))
prog := []string{
task.TaskTypeApplyStatefulSet,
task.TaskTypeApplyService,
TaskConfigPatch,
TaskConfigValidate,
task.TaskTypeReplacePod,
task.TaskTypeObserveImage,
TaskMarkReady,
}
return assembleUpdatePlan(node, prog, externalAddressPatch(node))
}
if sidecarNeedsReapproval(node) {
return buildMarkReadyPlan(node)
}
return nil, nil
}

func (p *archiveNodePlanner) controllerOverrides(node *seiv1alpha1.SeiNode) map[string]string {
Expand Down
33 changes: 29 additions & 4 deletions internal/planner/full.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ import (
"fmt"

seiconfig "github.com/sei-protocol/sei-config"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

seiv1alpha1 "github.com/sei-protocol/sei-k8s-controller/api/v1alpha1"
"github.com/sei-protocol/sei-k8s-controller/internal/task"
)

type fullNodePlanner struct {
Expand All @@ -30,17 +32,40 @@ func (p *fullNodePlanner) Validate(node *seiv1alpha1.SeiNode) error {

func (p *fullNodePlanner) BuildPlan(node *seiv1alpha1.SeiNode) (*seiv1alpha1.TaskPlan, error) {
if node.Status.Phase == seiv1alpha1.PhaseRunning {
return buildRunningPlan(node)
return p.buildRunningPlan(node)
}
fn := node.Spec.FullNode
params := &seiconfig.ConfigIntent{
intent := &seiconfig.ConfigIntent{
Mode: seiconfig.ModeFull,
Overrides: mergeOverrides(mergeOverrides(commonOverrides(node), p.controllerOverrides(node)), node.Spec.Overrides),
}
if NeedsBootstrap(node) {
return buildBootstrapPlan(node, node.Spec.Peers, fn.Snapshot, params)
return buildBootstrapPlan(node, node.Spec.Peers, fn.Snapshot, intent)
}
return buildBasePlan(node, node.Spec.Peers, fn.Snapshot, params)
return buildBasePlan(node, node.Spec.Peers, fn.Snapshot, intent)
}

// buildRunningPlan returns the update plan for a Running full node, or
// nil if no drift. pelletier/go-toml/v2 does not preserve comments on
// re-encode — the first config-patch erases operator-added comments.
func (p *fullNodePlanner) buildRunningPlan(node *seiv1alpha1.SeiNode) (*seiv1alpha1.TaskPlan, error) {
if imageDrifted(node) {
setNodeUpdateCondition(node, metav1.ConditionTrue, "UpdateStarted", imageDriftMessage(node))
prog := []string{
task.TaskTypeApplyStatefulSet,
task.TaskTypeApplyService,
TaskConfigPatch,
TaskConfigValidate,
task.TaskTypeReplacePod,
task.TaskTypeObserveImage,
TaskMarkReady,
}
return assembleUpdatePlan(node, prog, externalAddressPatch(node))
}
if sidecarNeedsReapproval(node) {
return buildMarkReadyPlan(node)
}
return nil, nil
}

func (p *fullNodePlanner) controllerOverrides(node *seiv1alpha1.SeiNode) map[string]string {
Expand Down
Loading
Loading