Deserialization API #16
Draft
+1,448
−845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface still isn't what it should be
Still not tested!
Functions map_errors, collapse_errors, then, and run_decoders have been added
No idea why it was like that to begin with since not taking `lua` defeats the purpose of decode.run returning `lua`
Contributor
Author
|
Future me, don't forget that |
I should do more tests on how lua state actually gets passed through decoders since using vibes isn't the best idea for a library. Also deserializing something with deser.run shouldn't mutate state.
1. Deserializers should not mutate state 2. It is difficult to implement consistently 3. Custom decoders are harder to write 4. #(lua, data)
Contributor
Author
|
I have decided that after 38 commits, I am mostly happy with this APi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new API creates a decoder style interface for deserializing
ValueRefs.Values have been removed.