Add a Valgrind GitHub Actions workflow

.github/workflows/valgrind.yml

@@ -0,0 +1,59 @@
+name: Valgrind
+on:
+  workflow_dispatch:
+  release:
+    types: [created]
+  push:
+    branches:
+      - rc-v*
+  pull_request:
+    paths:
+      - src/*.[hc]pp
+
+concurrency:
+  # Group by workflow and ref; the last component ensures that for pull
+  # requests, we limit to 1 concurrent job, but for the main branch we don't
+  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.ref != 'refs/heads/main' || github.run_number }}
+  # Only cancel intermediate pull request builds
+  cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}
+
+jobs:
+  test-valgrind:
+    name: "Ubuntu / GAP stable-4.15 / valgrind"
+    runs-on: ubuntu-latest
+    env:
+      NO_COVERAGE: true
+      VALGRIND: valgrind --trace-children=yes --leak-check=full --show-leak-kinds=all --error-exitcode=1
+    steps:
+      - uses: actions/checkout@v5
+      - name: "Output g++ version . . ."
+        run: g++ --version
+      - name: "Install Valgrind . . ."
+        run: |
+          sudo apt-get update
+          sudo apt-get install valgrind
+      - name: "Install GAP . . ."
+        uses: gap-actions/setup-gap@v3
+        with:
+          gap-version: stable-4.15
+          configflags: --enable-valgrind
+      - name: "Build additional necessary GAP packages . . ."
+        run: |
+          cd ${GAPROOT}/pkg
+          ../bin/BuildPackages.sh --strict digraphs* io* orb* datastructures* profiling*
+      - name: "Build Semigroups . . ."
+        uses: gap-actions/build-pkg@v2
+        with:
+          CONFIGFLAGS: --disable-hpcombi
+      - name: "Run SemigroupsTestInstall . . ."
+        uses: gap-actions/run-pkg-tests@v4
+        with:
+          testfile: tst/github_actions/install.g
+          pre-gap: ${{ env.VALGRIND }}
+          coverage: false
+      - name: "Run SemigroupsTestStandard . . ."
+        uses: gap-actions/run-pkg-tests@v4
+        with:
+          testfile: tst/github_actions/valgrind.g
+          pre-gap: ${{ env.VALGRIND }}
+          coverage: false

gap/tools/utils.gi

@@ -197,6 +197,9 @@ SEMIGROUPS.TestDir := function(dir, arg)
     if "suppressStatusMessage" in RecNames(arg[1]) then
       opts.suppressStatusMessage := arg[1].suppressStatusMessage;
     fi;
+    if "exclude" in RecNames(arg[1]) then
+      opts.exclude := arg[1].exclude;
+    fi;
   elif Length(arg) <> 0 then
     ErrorNoReturn("there must be no arguments, or the argument ",
                   "must be a record");

gapbind14/src/gapbind14.cpp

@@ -25,10 +25,8 @@
 
 #include "gapbind14/gap_include.hpp"  // for Obj etc
 
-#define GVAR_ENTRY(srcfile, name, nparam, params)                \
-  {                                                              \
-#name, nparam, params, (ObjFunc) name, srcfile ":Func" #name \
-  }
+#define GVAR_ENTRY(srcfile, name, nparam, params) \
+  {#name, nparam, params, (ObjFunc) name, srcfile ":Func" #name}
 
 namespace gapbind14 {
   UInt T_GAPBIND14_OBJ = 0;
@@ -104,21 +102,21 @@ namespace gapbind14 {
 
   void Module::clear() {
     for (auto &func : _funcs) {
-      delete func.name;
+      delete[] func.name;
       if (func.nargs != 0) {
-        delete func.args;
+        delete[] func.args;
       }
-      delete func.cookie;
+      delete[] func.cookie;
     }
     _funcs.clear();
 
     for (auto &vec : _mem_funcs) {
       for (auto &func : vec) {
-        delete func.name;
+        delete[] func.name;
         if (func.nargs != 0) {
-          delete func.args;
+          delete[] func.args;
         }
-        delete func.cookie;
+        delete[] func.cookie;
       }
       vec.clear();
     }

src/bipart.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2016 James D. Mitchell
+// Copyright (C) 2016-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/bipart.hpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2016 James D. Mitchell
+// Copyright (C) 2016-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/conglatt.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2022 James D. Mitchell
+// Copyright (C) 2022-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/conglatt.hpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2022 James D. Mitchell
+// Copyright (C) 20222-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/froidure-pin-fallback.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2016-2022 James D. Mitchell
+// Copyright (C) 2016-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/froidure-pin-fallback.hpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2016-2022 James D. Mitchell
+// Copyright (C) 2016-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-cong.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021-26 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-cong.hpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021-26 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-froidure-pin-base.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2022 James D. Mitchell
+// Copyright (C) 2022-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-froidure-pin-bipart.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-froidure-pin-bmat.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-froidure-pin-matrix.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-froidure-pin-max-plus-mat.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-froidure-pin-min-plus-mat.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-froidure-pin-pbr.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-froidure-pin-pperm.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-froidure-pin-transf.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-froidure-pin.hpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-to-congruence.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021-26 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/init-to-froidure-pin.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021-26 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/pkg.hpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2016-2022 James D. Mitchell
+// Copyright (C) 2016-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/semigroups-debug.hpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2017 James D. Mitchell
+// Copyright (C) 2017-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/to-cpp.hpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2020-2022 James D. Mitchell
+// Copyright (C) 2020-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/to-gap.cpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2021 James D. Mitchell
+// Copyright (C) 2021-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

src/to-gap.hpp

@@ -1,6 +1,6 @@
 //
 // Semigroups package for GAP
-// Copyright (C) 2020-2022 James D. Mitchell
+// Copyright (C) 2020-2026 James D. Mitchell
 //
 // This program is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

tst/github_actions/examples.g

@@ -0,0 +1,7 @@
+LoadPackage("semigroups", false);;
+if SEMIGROUPS.TestManualExamples() then
+  QUIT_GAP(0);
+else
+  QUIT_GAP(1);
+fi;
+FORCE_QUIT_GAP(1);

tst/github_actions/extreme.g

@@ -0,0 +1,7 @@
+LoadPackage("semigroups", false);;
+if SemigroupsTestExtreme(rec(earlyStop := false)) then
+  QUIT_GAP(0);
+else
+  QUIT_GAP(1);
+fi;
+FORCE_QUIT_GAP(1);

tst/github_actions/install.g

@@ -0,0 +1,7 @@
+LoadPackage("semigroups", false);;
+if SemigroupsTestInstall() then
+  QUIT_GAP(0);
+else
+  QUIT_GAP(1);
+fi;
+FORCE_QUIT_GAP(1);

tst/github_actions/standard.g

@@ -0,0 +1,7 @@
+LoadPackage("semigroups", false);;
+if SemigroupsTestStandard(rec(earlyStop := false)) then
+  QUIT_GAP(0);
+else
+  QUIT_GAP(1);
+fi;
+FORCE_QUIT_GAP(1);

tst/github_actions/valgrind.g

@@ -0,0 +1,8 @@
+LoadPackage("semigroups", false);;
+if SemigroupsTestStandard(
+    rec(earlyStop := false, exclude := ["fp/tietze.tst"])) then
+  QUIT_GAP(0);
+else
+  QUIT_GAP(1);
+fi;
+FORCE_QUIT_GAP(1);