Add index management commands#335
Open
Jonas-Puksta-Sensmetry wants to merge 24 commits into
Open
Conversation
Jonas-Puksta-Sensmetry
force-pushed
the
pr/index-management
branch
2 times, most recently
from
857c51f to
20e5dcc
Compare
…, and `sysand index remove` Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Jonas-Puksta-Sensmetry
force-pushed
the
pr/index-management
branch
from
20e5dcc to
494e940
Compare
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
…eporting of `sysand index remove` Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
… of using cwd and add an initial index test Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
…more testing Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Jonas-Puksta-Sensmetry
requested review from
andrius-puksta-sensmetry and
consideRatio
Collaborator
Author
|
@andrius-puksta-sensmetry @consideRatio I'll add more tests and update documentation, but other parts are ready for review |
…and add a bit more testing Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
…json and iri, and make sure to construct iri from normalized publisher and version Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
…ge in case that is not a directory Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
…it's not needed Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
consideRatio
approved these changes
May 15, 2026
Collaborator
consideRatio
left a comment
consideRatio
left a comment
There was a problem hiding this comment.
Nice @Jonas-Puksta-Sensmetry!!
I let codex make two PRs reflecting the two main non-blocking feedback points I had:
- I see index_utils.rs to contain shared data models between env/index.rs and commands/index/..., but think _utils doesn't reflect that, so I refactored it into index/{model|iri}.rs instead
PR to your PR with this change: Jonas-Puksta-Sensmetry#1 - I see commands/index/mod_tests.rs as integration tests, and as such they would belong into the core/tests folder.
PR to your PR with this change, and point 1, Jonas-Puksta-Sensmetry#2
| #[derive(Debug, Serialize, Deserialize, Default)] | ||
| pub(crate) struct IndexJson { | ||
| pub(crate) projects: Vec<IndexProject>, | ||
| } |
Collaborator
There was a problem hiding this comment.
I understand this has been lifted from core/src/env/index.rs, as it's now used by commands/index/ and env/
Since this file contains data structures of essence to these, naming it ..._utils.rs feels misleading, so maybe splitting this file into core/src/index/ and the files mod.rs / model.rs / iri.rs instead?
I opened Jonas-Puksta-Sensmetry#1 with such change, done with codex gpt 5.5 using mostly the comment above as a prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.