Skip to content

feat: Capture and report backend error message on checkout failure #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Capture and report backend error message on checkout failure #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions app/src/main/java/com/example/vu/android/empowerplant/MainFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,15 +353,27 @@ public void checkout() {
public void onResponse(@NotNull Call call, @NotNull Response response) throws IOException {
progressDialog.dismiss();
boolean success = response.isSuccessful();
String errorMessage = null;
if (!success) {
// Read the response body before closing to get the actual error message
try {
if (response.body() != null) {
errorMessage = response.body().string();
}
} catch (Exception e) {
Log.e("checkout", "Failed to read error response body", e);
}
}
response.close();
if (!success) {
Log.w("checkout", "response failed");
final String finalErrorMessage = errorMessage;
Log.w("checkout", "response failed with status: " + response.code() + ", body: " + errorMessage);
runOnUiThread(new Runnable() {
@Override
public void run() {
progressDialog.dismiss();

processDeliveryItem(checkoutTransaction);
processDeliveryItem(checkoutTransaction, finalErrorMessage);

checkoutTransaction.finish(SpanStatus.INTERNAL_ERROR);
}
Expand Down Expand Up @@ -420,11 +432,19 @@ private JSONObject buildJSONPostData(List<StoreItem> selectedStoreItems) {
}

private void processDeliveryItem(ITransaction checkoutTransaction) {
processDeliveryItem(checkoutTransaction, null);
}

private void processDeliveryItem(ITransaction checkoutTransaction, String backendErrorMessage) {
Log.i("processDeliveryItem", "processDeliveryItem >>>");
ISpan processDeliverySpan = checkoutTransaction.startChild("task", "process delivery");

try {
throw new MainFragment.BackendAPIException("Failed to init delivery workflow.");
String errorMessage = "Failed to init delivery workflow.";
if (backendErrorMessage != null && !backendErrorMessage.isEmpty()) {
errorMessage = errorMessage + " Backend error: " + backendErrorMessage;
}
throw new MainFragment.BackendAPIException(errorMessage);
} catch (Exception e) {
Log.e("processDeliveryItem", e.getMessage());
processDeliverySpan.setThrowable(e);
Expand Down