Skip to content

feat: Create version TOML file, upgrade gradle and all dependencies [COMP-1266]#583

Open
cristianrcv wants to merge 14 commits intomasterfrom
feat/COMP-1266-create-toml-file-and-upgrade-deps
Open

feat: Create version TOML file, upgrade gradle and all dependencies [COMP-1266]#583
cristianrcv wants to merge 14 commits intomasterfrom
feat/COMP-1266-create-toml-file-and-upgrade-deps

Conversation

@cristianrcv
Copy link

@cristianrcv cristianrcv commented Feb 20, 2026

Description

  • Create version TOML file to automate dependency update
  • Upgrade gradle to 9.3.1
  • Upgrade dependencies to latest available stable versions
  • Upgrade tower SDK version to 1.109.0
  • Upgrade CLI version to 0.22.0

Suggestion

  • Review commit by commit as applying the new license header modified many files

@cristianrcv cristianrcv requested a review from a team February 20, 2026 08:57
@cristianrcv cristianrcv marked this pull request as draft February 20, 2026 09:07
@cristianrcv
Copy link
Author

@claude review

@cristianrcv cristianrcv marked this pull request as ready for review February 20, 2026 13:11
@cristianrcv
Copy link
Author

@swampie @tcrespog After these changes, should I release the new artifact by adding a release commit? Do you know how do we usually do in this project?

@@ -1,4 +1,4 @@
1.98.0
1.109.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, upgrading platform version API to latest cloud api available

@cristianrcv cristianrcv requested review from a team and alberto-miranda February 20, 2026 13:19
@@ -1,3 +1,3 @@
0.21.0
0.22.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my idea is to release this as next version (includes dependency version bumps that need to be solved for a security issue due next sprint)

@@ -1,4 +1,4 @@
Copyright ${year}, ${name}.
Copyright 2021-2026, Seqera.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the good one was the template one

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new license header template does not allow customizable placeholders. The old one is not compatible with Gradle 9.x because it was discontinued. Since this file is still a template I would argue is not so much of an issue: you change the year once in here and run the applyLicense

@@ -1,7 +1,7 @@
{
"serviceInfo": {
"version": "22.3.0-torricelli",
"apiVersion": "1.98.0",
"apiVersion": "1.109.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when changing the version the mocks of the tests must be updated too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments