Add support for complex number datatypes#129
Open
bogdanteleaga wants to merge 1 commit intoserizba:masterfrom
Open
Add support for complex number datatypes#129bogdanteleaga wants to merge 1 commit intoserizba:masterfrom
bogdanteleaga wants to merge 1 commit intoserizba:masterfrom
Conversation
This PR aims to add support for complex number datatypes. Only tested with `std::complex<float>` but I imagine it works just as well with `std::complex<double>`.
serizba
force-pushed
the
master
branch
2 times, most recently
from
3326662 to
c98a475
Compare
Owner
|
Did you test this? Isn't float 32 bits, and double 64? You are using them as 64 and 128. |
Author
|
Hello! I didn't end up using it, but I believe it's like that because the complex numbers are a pair of float/double. |
Owner
|
True, I will test this and include it |
serizba
added
requires-testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add support for complex number datatypes. Only tested with
std::complex<float>but I imagine it works just as well withstd::complex<double>.