Fixes bug where messages from frameId 0 weren't having sender.frameId set#28
Open
gurupras wants to merge 2 commits intoserversideup:mainfrom
Open
Fixes bug where messages from frameId 0 weren't having sender.frameId set#28gurupras wants to merge 2 commits intoserversideup:mainfrom
gurupras wants to merge 2 commits intoserversideup:mainfrom
Conversation
Collaborator
|
Hi @gurupras, can you please re-visit this against the |
Collaborator
|
@gurupras checking in if you were able to test |
mmxcrono
reviewed
May 8, 2023
| const portFrame = incomingPort.sender.frameId | ||
|
|
||
| if (portFrame) | ||
| if (portFrame !== undefined) |
There was a problem hiding this comment.
This would allow nulls to pass this check. Should this be portFrame || portFrame === 0 instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A value of
0forframeIdis valid. However, the existing code was skipping this due to a truthiness check. This has been replaced with an explicitframeId === undefinedcheck instead.