Skip to content

Optimize GenericExpressionVisitor.VisitUnknown() #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergeiPavlov merged 1 commit into from
May 12, 2026
Merged

Optimize GenericExpressionVisitor.VisitUnknown() #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Orm/Xtensive.Orm/Orm/Linq/Expressions/Visitors/GenericExpressionVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,9 @@ protected override Expression VisitUnknown(Expression e)
if (e is T mapped)
return VisitGenericExpression(mapped);

if (e is ExtendedExpression extendedExpression && extendedExpression.ExtendedType == ExtendedExpressionType.Marker) {
var marker = (MarkerExpression) e;
var result = Visit(marker.Target);
if (result == marker.Target)
if (e is MarkerExpression { Target: var target } marker) {
Copy link
Copy Markdown

@snaumenko-st snaumenko-st May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that it's a not necessary check? It's not obvious

Copy link
Copy Markdown
Collaborator Author

@SergeiPavlov SergeiPavlov May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. MarkerExpression is a sealed type
ExtendedType == ExtendedExpressionType.Marker and is MarkerExpression are equal conditions

var result = Visit(target);
if (result == target)
return result;
return new MarkerExpression(result, marker.MarkerType);
}
Expand Down
Loading