Skip to content

Optimize SqlDml.Literal()/.Array() by using ConstructorInvoker #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergeiPavlov merged 2 commits into from
May 12, 2026
Merged

Optimize SqlDml.Literal()/.Array() by using ConstructorInvoker #485

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cfd875
Optimize `SqlDml.Literal()/.Array()` by using `ConstructorInvoker`
SergeiPavlov May 12, 2026
0077083
Simplify
SergeiPavlov May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 17 additions & 32 deletions Orm/Xtensive.Orm/Sql/SqlDml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,11 @@
// This code is distributed under MIT license terms.
// See the License.txt file in the project root for more information.

using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Collections.Concurrent;
using System.Reflection;
using Xtensive.Collections;
using Xtensive.Core;
using Xtensive.Reflection;
using Xtensive.Sql.Dml;
using Xtensive.Sql.Model;
using System.Linq;

namespace Xtensive.Sql
{
Expand All @@ -20,16 +15,15 @@ namespace Xtensive.Sql
/// </summary>
public static class SqlDml
{
private static readonly Type
SqlArrayOfTType = typeof(SqlArray<>),
SqlLiteralOfTType = typeof(SqlLiteral<>);

public static readonly SqlDefaultValue DefaultValue = new SqlDefaultValue();
public static readonly SqlNull Null = new SqlNull();
public static readonly SqlBreak Break = new SqlBreak();
public static readonly SqlContinue Continue = new SqlContinue();
public static readonly SqlNative Asterisk = Native("*");

private static readonly ConcurrentDictionary<Type, ConstructorInvoker> LiteralConstructorByType = new();
private static readonly ConcurrentDictionary<Type, ConstructorInvoker> ArrayConstructorByType = new();

#region Aggregates

public static SqlAggregate Count()
Expand Down Expand Up @@ -144,6 +138,12 @@ public static SqlBinary Modulo(SqlExpression left, SqlExpression right)

#region Array

private static SqlArray ConstructSqlArrayOfType(Type type, object[] values) =>
(SqlArray) ArrayConstructorByType.GetOrAdd(type, static t =>
ConstructorInvoker.Create(typeof(SqlArray<>).CachedMakeGenericType(t)
.GetConstructor(BindingFlags.CreateInstance | BindingFlags.Instance | BindingFlags.NonPublic, null, [typeof(object[])], null)!)
).Invoke([values]);

public static SqlArray Array(IEnumerable<object> values)
{
var valueList = values.ToArray();
Expand All @@ -154,12 +154,7 @@ public static SqlArray Array(IEnumerable<object> values)
if (!itemType.IsAssignableFrom(t))
throw new ArgumentException(Strings.ExTypesOfValuesAreDifferent);
}
var resultType = SqlArrayOfTType.CachedMakeGenericType(itemType);
var result = Activator.CreateInstance(
resultType,
BindingFlags.CreateInstance | BindingFlags.Instance | BindingFlags.NonPublic,
null, new object[] {valueList}, null);
return (SqlArray) result;
return ConstructSqlArrayOfType(itemType, valueList);
}

public static SqlArray Array(object[] values)
Expand All @@ -172,12 +167,7 @@ public static SqlArray Array(object[] values)
throw new ArgumentException(Strings.ExTypesOfValuesAreDifferent);
}

var resultType = SqlArrayOfTType.CachedMakeGenericType(itemType);
var result = Activator.CreateInstance(
resultType,
BindingFlags.CreateInstance | BindingFlags.Instance | BindingFlags.NonPublic,
null, new object[] { values }, null);
return (SqlArray) result;
return ConstructSqlArrayOfType(itemType, values);
}

public static SqlArray<bool> Array(params bool[] value)
Expand Down Expand Up @@ -1175,16 +1165,11 @@ public static SqlLiteral<Guid> Literal(Guid value)
return new SqlLiteral<Guid>(value);
}

public static SqlLiteral Literal(object value)
{
var valueType = value.GetType();
var resultType = SqlLiteralOfTType.CachedMakeGenericType(valueType);
var result = Activator.CreateInstance(
resultType,
BindingFlags.CreateInstance | BindingFlags.Instance | BindingFlags.NonPublic,
null, new[] {value}, null);
return (SqlLiteral) result;
}
public static SqlLiteral Literal(object value) =>
(SqlLiteral) LiteralConstructorByType.GetOrAdd(value.GetType(), static t =>
ConstructorInvoker.Create(typeof(SqlLiteral<>).CachedMakeGenericType(t)
.GetConstructor(BindingFlags.CreateInstance | BindingFlags.Instance | BindingFlags.NonPublic, null, [t], null)!)
).Invoke(value);

public static SqlExpression LiteralOrContainer(object value)
{
Expand Down
Loading