Optimize ExpressionMaterializer.CreateEntity()#486
Merged
Conversation
snaumenko-st
approved these changes
May 12, 2026
| index = entityRegistry.Count; | ||
| entityRegistry.Add(expression, index); | ||
| } | ||
| ref var indexRef = ref CollectionsMarshal.GetValueRefOrAddDefault(entityRegistry, expression, out var exists); |
There was a problem hiding this comment.
IMHO too dangerous. And my previous benchmarks haven't indicated the significant performance boost. So probably it's not worth it
Collaborator
Author
There was a problem hiding this comment.
Why can it be dangerous?
.NET implementation of Dictionary.TryAdd() uses it inside
And here is some benchmark showing the performance gain https://matthewcrews.com/blog/2022/03/performance-of-key-value-lookups-types/
There was a problem hiding this comment.
It's easy to use it wrong way. That's it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid double Dictionary lookup