-
Notifications
You must be signed in to change notification settings - Fork 254
Test groupadd and groupmod -U option with empty user list #1427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks! Could you please remove the bugfix patches? That should show in the CI the failures, which will make sure that the tests actually do their job. |
10f27b4 to
9d205a3
Compare
alejandro-colomar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! @hallyn , would you mind merging first this PR, and then mine?
Done! |
|
Please rebase. |
9d205a3 to
44bba1d
Compare
|
Done |
|
Do you mind adding a test which creates three users, adds them to the new group, then uses usermod -U to change the group to only have two of the users? |
That should go in a separate PR, right? |
Well, a separate commit. The PR could just be "usermod -U tests". But ok. |
Done, but I'm assuming you meant |
fb1190f to
5852a15
Compare
|
Hm, do you know what's up with the failing tests? |
|
This PR doesn't include the fixes from #1422, thus it makes sense that tests are failing |
…pty string Test verifies that groupmod -U '' correctly clears group membership. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
…pty string Test verifies that groupadd -U '' correctly creates group with no members. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
5852a15 to
7e93552
Compare
Tests: #1422