Skip to content

Conversation

@ikerexxe
Copy link
Collaborator

Tests: #1422

@alejandro-colomar
Copy link
Collaborator

Thanks! Could you please remove the bugfix patches? That should show in the CI the failures, which will make sure that the tests actually do their job.

Copy link
Collaborator

@alejandro-colomar alejandro-colomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! @hallyn , would you mind merging first this PR, and then mine?

@ikerexxe
Copy link
Collaborator Author

Thanks! Could you please remove the bugfix patches? That should show in the CI the failures, which will make sure that the tests actually do their job.

Done!

@alejandro-colomar
Copy link
Collaborator

Please rebase.

@ikerexxe
Copy link
Collaborator Author

Done

@hallyn
Copy link
Member

hallyn commented Dec 22, 2025

Do you mind adding a test which creates three users, adds them to the new group, then uses usermod -U to change the group to only have two of the users?

@alejandro-colomar
Copy link
Collaborator

Do you mind adding a test which creates three users, adds them to the new group, then uses usermod -U to change the group to only have two of the users?

That should go in a separate PR, right?

@hallyn
Copy link
Member

hallyn commented Dec 23, 2025

Do you mind adding a test which creates three users, adds them to the new group, then uses usermod -U to change the group to only have two of the users?

That should go in a separate PR, right?

Well, a separate commit. The PR could just be "usermod -U tests".

But ok.

@ikerexxe
Copy link
Collaborator Author

Do you mind adding a test which creates three users, adds them to the new group, then uses usermod -U to change the group to only have two of the users?

Done, but I'm assuming you meant groupmod -U and not usermod -U. The latter checks a different thing

@hallyn
Copy link
Member

hallyn commented Dec 26, 2025

Hm, do you know what's up with the failing tests?

@ikerexxe
Copy link
Collaborator Author

This PR doesn't include the fixes from #1422, thus it makes sense that tests are failing

…pty string

Test verifies that groupmod -U '' correctly clears group membership.

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
…pty string

Test verifies that groupadd -U '' correctly creates group with no
members.

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
@hallyn hallyn merged commit 07d9c2d into shadow-maint:master Dec 29, 2025
7 of 11 checks passed
@ikerexxe ikerexxe deleted the test-regression branch December 29, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants