-
Notifications
You must be signed in to change notification settings - Fork 254
sg: Fix usage and manual page #1458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use "an" in front of sg due to its pronounciation. Also, start a comment with capital letter in its first sentence to comply with other comments. No functional change. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
The group argument is not optional, so do not specify it as such in the manual page. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
The usage message of sg and synopsis of its manual page diverged. The difference was even noted in a comment, instead of fixing it. Synchronize both, add information about hidden options and document what they do. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
|
Closing this PR due to chatter overflow. Based on these suggestions, someone who is actually willing to progress can find a solution. See #1460 |
I'm actually willing to progress. I said I'm okay with the commits as they are. I'd just like to improve this with a fourth commit that makes it even better. The documentation, as you've improved it, still doesn't document the actual behavior: the synopsis doesn't say anything about At least the paragraphs now are understandable, so I'm happy to merge this as is. |
I assume that the different styles of usage messages and manual pages across the various shadow tools must be the reason why people stop using shadow where possible because they are confusing to them? Is it documented anywhere how these are supposed to look like or is a mixture of various styles actually what you want (in which case it doesn't make sense to "fix" this very one manual page, since it adds variation)?
You might want to adjust the |
I don't know. All of that predates my involvement in the project (and even in programming), and I'm not a distribution maintainer, so I don't know why distros prefer some binaries from shadow and some from other projects.
I'm not talking about style here. I'm talking about undocumented features. But as we discussed in the other PR, what should probably do is to change the behavior of sg(1) to align with that of su(1).
I have been wanting to fix the manual pages for a long time, indeed. It's just that the XML is too painful for me to do it. I might eventually port them to man(7) source code and improve them from there. |
The usage message of
sgand its manual page contain different information. Synchronize both and document whatsg's options do.