Drop libattr dependency #1473
Merged
Drop libattr dependency #1473
+17
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
approved these changes
Jan 3, 2026
Collaborator
alejandro-colomar
left a comment
alejandro-colomar
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
Reviewed-by: Alejandro Colomar <alx@kernel.org>
Collaborator
|
It LGTM. Do you want to wait for @ikerexxe 's review? I'd be happy to merge now and expand later if appropriate; the current patch makes sense to me. |
Contributor
Author
|
I'd prefer to wait. I wonder if this actually reveals a bug or a feature that was missed. If it's 100 % sure that we really don't want libattr, then we can merge. |
ikerexxe
reviewed
Jan 7, 2026
Collaborator
ikerexxe
left a comment
ikerexxe
left a comment
There was a problem hiding this comment.
I can still see three references to LIBATTR in Makefile.am files. Can you remove them?
The reset_selinux flag is always true, so it can be removed. Remove all functions which are not used anymore as well. Reviewed-by: Alejandro Colomar <alx@kernel.org> Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
The libattr dependency is no longer needed. Reviewed-by: Alejandro Colomar <alx@kernel.org> Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
Contributor
Author
Removed. Thanks for careful review! :) |
ikerexxe
approved these changes
Jan 8, 2026
Collaborator
ikerexxe
left a comment
ikerexxe
left a comment
There was a problem hiding this comment.
LGTM! Thank you for taking care of that too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted this while rebuilding the Arch Linux shadow package, which gave me the warning that libattr is not needed (even though referred to by PKGBUILD file).
Turns out: It's absolutely correct!
And here's the history of the whole thing:
791ebc5 -- Added
reset_selinuxflag (useraddset it tofalse,usermodset it totrue)06eb4e4 -- Made both tools set it to
true74c17c7 -- Introduced a
falsecall inuseradd48aa12a -- Made both tools set it to
trueagainSo, as long as @ikerexxe agrees, this disabled
libattrsupport for a few years and nobody complained. In fact, people complained when it was enabled.I keep 786e44f as it is, unless @ikerexxe says that it can be removed now.