Skip to content

F bimanual teleop tweaks#48

Merged
chrisw-shadow merged 14 commits intonoetic-develfrom
F_bimanual_teleop_tweaks
Mar 24, 2026
Merged

F bimanual teleop tweaks#48
chrisw-shadow merged 14 commits intonoetic-develfrom
F_bimanual_teleop_tweaks

Conversation

@chrisw-shadow
Copy link
Copy Markdown
Contributor

Proposed changes

Some tweaks, mostly to launch files to enable proper launching of a bimanual system.

Also duplicated the controllers' configs so that the 2nd arm doesn't complain about it

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. This is a reminder of what we should look for before merging this code. I have:

  • Read and follow the contributing guidelines.
  • Checked that all tests pass with my changes
  • Added tests (automatic or manual) that prove the fix is effective or that the feature works
  • Added necessary documentation (if appropriate)
  • Added the corresponding license to each file and add the current year of any one that you modified.
  • Tested on real hardware (if appropriate)

Comment thread dx_launch/launch/dexee_driver_only.launch.xml
Comment thread dx_launch/scripts/construct_robot_description
Comment thread dx_launch/launch/start_bimanual.launch Outdated
</group>

<!-- Loading robot description for system 0-->
<group ns="a0">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we being consistent with the namespace naming?
I see some called hand_0, but then we call these a0 instead of arm_0.
I can't remember what was our agreed convention on this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye I think you're right here, changed them to arm_0 and arm_1. although I don't think it actually matters in this case cos the namespacing doesnt actually do anything to the description that gets loaded (other than breaking the convention)

@chrisw-shadow chrisw-shadow requested a review from toliver March 23, 2026 14:49
@chrisw-shadow chrisw-shadow merged commit bd4235d into noetic-devel Mar 24, 2026
3 checks passed
@chrisw-shadow chrisw-shadow deleted the F_bimanual_teleop_tweaks branch March 24, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants