Merged
Conversation
niko-holmes
reviewed
Mar 18, 2026
niko-holmes
approved these changes
Mar 19, 2026
toliver
requested changes
Mar 23, 2026
| </group> | ||
|
|
||
| <!-- Loading robot description for system 0--> | ||
| <group ns="a0"> |
Contributor
There was a problem hiding this comment.
Are we being consistent with the namespace naming?
I see some called hand_0, but then we call these a0 instead of arm_0.
I can't remember what was our agreed convention on this.
Contributor
Author
There was a problem hiding this comment.
ye I think you're right here, changed them to arm_0 and arm_1. although I don't think it actually matters in this case cos the namespacing doesnt actually do anything to the description that gets loaded (other than breaking the convention)
toliver
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Some tweaks, mostly to launch files to enable proper launching of a bimanual system.
Also duplicated the controllers' configs so that the 2nd arm doesn't complain about it
Types of changes
What types of changes does your code introduce?
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. This is a reminder of what we should look for before merging this code. I have: