fix test_data for vapps tests

[shwstppr]

Adds test data for vApps tests (test_vm_life_cycle.py).

[shwstppr]

@nvazquez vApps tests in test_vm_life_cycle.py were failing on Trillian as test_data was not having the required details.

2021-03-10 01:17:30,654 - CRITICAL - EXCEPTION: test_01_unmanage_vm_cycle: ['Traceback (most recent call last):\n', '  File "/usr/lib/python2.7/site-packages/nose/suite.py", line 209, in run\n    self.setUp()\n', '  File "/usr/lib/python2.7/site-packages/nose/suite.py", line 292, in setUp\n    self.setupContext(ancestor)\n', '  File "/usr/lib/python2.7/site-packages/nose/suite.py", line 315, in setupContext\n    try_run(context, names)\n', '  File "/usr/lib/python2.7/site-packages/nose/util.py", line 471, in try_run\n    return func()\n', '  File "/marvin/tests/smoke/test_vm_life_cycle.py", line 1752, in setUpClass\n    cls.services[\'test_ovf_templates\'],\n', "KeyError: 'test_ovf_templates'\n"]

I added the changes and have copied http://10.2.0.4/marvin/machina-2dd-iso.ova from http://10.5.1.128/templates/machina-2dd-iso.ova.

2021-03-10 08:28:35,071 - CRITICAL - EXCEPTION: None: ['Traceback (most recent call last):\n', '  File "/usr/lib/python2.7/site-packages/nose/suite.py", line 209, in run\n    self.setUp()\n', '  File "/usr/lib/python2.7/site-packages/nose/suite.py", line 292, in setUp\n    self.setupContext(ancestor)\n', '  File "/usr/lib/python2.7/site-packages/nose/suite.py", line 315, in setupContext\n    try_run(context, names)\n', '  File "/usr/lib/python2.7/site-packages/nose/util.py", line 471, in try_run\n    return func()\n', '  File "/marvin/tests/smoke/atest.py", line 97, in setUpClass\n    assert False, "get_test_ovf_templates() failed to return templates"\n', 'AssertionError: get_test_ovf_templates() failed to return templates\n']

Can you please check if the OVF template is correct or do we need to change get_test_ovf_templates method.

PS: Before bf597e5 Trillian was having a different version of test_vm_life_cycle.py

[yadvr]

@shwstppr is this ready for merging? cc @Pearl1594 @davidjumani

[shwstppr]

@rhtyd I think issue is not there on Sofia lab. I'll check and reopen (with changes) if needed.

[shwstppr]

Verified issue is still there.
While this fixes the failing tests, @nvazquez need to verify template to be used, https://github.com/shapeblue/Trillian/pull/128/files#diff-27fd2cc7d23dbc532fb65312275e4dbb61bec62418aa849ecaa82296f2d40c51R1020

[yadvr]

@shwstppr can you check your branch - does it need rebasing, there are many additional commits than your change

[nvazquez]

Thanks @shwstppr, I've copied the .ova from '10.0.3.122/other_templates' to '10.0.3.122/marvin/' and placed your code on a marvin box '/marvin/test_data.py' file. Needed to fix the test as well, will be adding the code as well.

Test the following for all found ovf templates: ... === TestName: test_01_vapps_vm_cycle | Status : SUCCESS ===
ok

[nvazquez]

PR containing the marvin tests changes: apache/cloudstack#4738

[nvazquez]

@shwstppr we might consider rebasing the branch vmware-sofia-lab instead of sofia-lab