fix(nginx): add comprehensive MIME type mappings#348
Merged
sharevb merged 2 commits intosharevb:chore/all-my-stuffsfrom Apr 12, 2026
Merged
fix(nginx): add comprehensive MIME type mappings#348sharevb merged 2 commits intosharevb:chore/all-my-stuffsfrom
sharevb merged 2 commits intosharevb:chore/all-my-stuffsfrom
Conversation
- Expanded types directive with complete MIME type definitions. - Added mappings for common file types including HTML, CSS, images, fonts, documents, videos, audio, and archives. - Replaced minimal JavaScript-only configuration with full nginx default types.
Owner
|
Hi @dragonish many thanks for this PR, I merged previous too early, could it be better to do something like that : storybookjs/storybook#20157 (comment) |
Removed numerous MIME type definitions and added include for mime.types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Reason
The changes in #347 caused the default Nginx
typesblock to be overridden. This resulted in all other resources (such as HTML files) having theirContent-Typeresponse header incorrectly set toapplication/octet-streamafter building the Docker image, preventing them from functioning properly.