feat: add var_default config option#370
Open
ethanpailes wants to merge 1 commit intomasterfrom
Open
Conversation
This patch adds a new var_default config option allowing users
to set initial values for variables on daemon startup.
I want this because I want to be able to set a default workspace
var so I can know that it is always safe to connect to
`{workspace}-edit` and not have to worry about the daemon being
in a state where workspace is not yet set. This is possible to
hack together today with a series of `shpool var get` and
`shpool var set` commands in a wrapper script, but I want
it as a first-party feature.
I tweaked some of the test utils to deflake as well.
ethanpailes
force-pushed
the
add-var-default-config
branch
from
268e66d to
903af90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
n/a
AI Policy Ack
Ack
This PR was:
I vibed the test.
Description
This patch adds a new var_default config option allowing users to set initial values for variables on daemon startup.
I want this because I want to be able to set a default workspace var so I can know that it is always safe to connect to
{workspace}-editand not have to worry about the daemon being in a state where workspace is not yet set. This is possible to hack together today with a series ofshpool var getandshpool var setcommands in a wrapper script, but I want it as a first-party feature.