Skip to content

Fixed memory leak issue while retrieving dynamodb records #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vinod0511 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed memory leak issue while retrieving dynamodb records #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 47 additions & 63 deletions lib/bin/dbInstanceData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,71 +51,55 @@ class DbInstanceData {
});
}

getRecords(keys) {
return new Promise((resolve, reject) => {

let dynamodb = new AWS.DynamoDB({ region: this.DbRegion });
let params = {
TableName: this.DbTable,
ExclusiveStartKey: null,
Limit: 100,
Select: 'ALL_ATTRIBUTES'
};

var numberOfRecords = 0;

function recursiveCall(params) {
return new Promise((rs, rj) => {

dynamodb.scan(params, (err, data) => {
if (err) {
return rj(err);
}

let records = [];
data.Items.forEach((item) => {
let id = {};
keys.forEach(key => {
id[key.AttributeName] = item[key.AttributeName];
});

let record = {
keys: JSON.stringify(id),
data: JSON.stringify(item),
event: 'INSERT'
};
records.push(record);
});

let promises = [];
records.forEach(record => {
promises.push(this.dbRecord.backup([record]));
});
Promise.all(promises)
.then(() => {
numberOfRecords += data.Items.length;
console.log('Retrieved ' + data.Items.length + ' records; total at ' + numberOfRecords + ' records.');
if (data.LastEvaluatedKey) {
params.ExclusiveStartKey = data.LastEvaluatedKey;
return recursiveCall.call(this, params).then(() => rs());
}
return rs();
})
.catch(err => {
rj(err);
});
});
});
}

recursiveCall.call(this, params)
.then(data => {
resolve()
}).catch(err =>{
reject(err);
async getRecords(keys) {
let dynamodb = new AWS.DynamoDB({ region: this.DbRegion });
let params = {
TableName: this.DbTable,
ExclusiveStartKey: null,
Limit: 100,
Select: "ALL_ATTRIBUTES",
};

var numberOfRecords = 0;

let LastEvaluatedKey = null;
do {
params.ExclusiveStartKey = LastEvaluatedKey;
let data = await dynamodb.scan(params).promise();

let records = [];
data.Items.forEach((item) => {
let id = {};
keys.forEach((key) => {
id[key.AttributeName] = item[key.AttributeName];
});
});

let record = {
keys: JSON.stringify(id),
data: JSON.stringify(item),
event: "INSERT",
};
records.push(record);
});

let promises = [];
records.forEach((record) => {
promises.push(this.dbRecord.backup([record]));
});
await Promise.all(promises);

numberOfRecords += data.Items.length;
console.log(
"Retrieved " +
data.Items.length +
" records; total at " +
numberOfRecords +
" records."
);
LastEvaluatedKey = data.LastEvaluatedKey;
} while (LastEvaluatedKey);
}


}

Expand Down