SG-40980 Add support for VFX CY2026 - Python 3.13 - Qt 6.8#1080
SG-40980 Add support for VFX CY2026 - Python 3.13 - Qt 6.8#1080julien-lang merged 13 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1080 +/- ##
=======================================
Coverage 79.63% 79.63%
=======================================
Files 198 198
Lines 20620 20620
=======================================
Hits 16420 16420
Misses 4200 4200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request adds support for Python 3.13 and updates the VFX Reference Platform compatibility while incorporating bug fixes and improvements to the vendored shotgun_api3 library. The changes ensure the codebase remains compatible with modern Python versions and follows current best practices.
Changes:
- Added Python 3.13 support with appropriate CI pipeline updates and compatibility adjustments
- Updated vendored
shotgun_api3to version 3.10.0 with improved error handling and code modernization - Fixed cross-platform file URL handling in tests and corrected deprecated API usage
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated badges to reflect support for VFX Platform CY2022-CY2026 and Python 3.9-3.13 |
| azure-pipelines.yml | Updated CI to use branch with Python 3.13 support |
| python/tank_vendor/shotgun_api3/init.py | Updated deprecation warning to recommend Python 3.13 |
| python/tank_vendor/shotgun_api3/shotgun.py | Bumped version to 3.10.0, fixed typo, improved docstrings, refactored error handling, and modernized datetime parsing |
| python/tank_vendor/shotgun_api3/lib/README.md | Removed outdated Python 2/3 compatibility note |
| python/tank_vendor/shotgun_api3/commit_id | Updated to reflect new vendored version |
| python/tank/util/pyside6_patcher.py | Added shims for exec_ methods to prevent warnings |
| tests/util_tests/test_shotgun.py | Fixed Windows file URL handling and updated to use keyword argument |
| tests/util_tests/test_sgre.py | Added conditional logic to handle Python 3.13 deprecation of positional arguments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
carlos-villavicencio-adsk
left a comment
There was a problem hiding this comment.
Great job! 🚀
This pull request updates support for newer Python and VFX Reference Platform versions, improves compatibility with Python 3.13, and includes several bug fixes and documentation updates. The most significant changes are compatibility improvements for Python 3.13, updates to documentation and badges, and minor bug fixes and refactoring in the vendored
shotgun_api3library.Python 3.13 and VFX Platform Support
README.mdto reflect support for VFX Reference Platform CY2022–CY2026 and Python 3.9, 3.10, 3.11, and 3.13.azure-pipelines.yml).Python Compatibility and Bug Fixes
pyside6_patcher.pyto prevent warnings forexec_methods, improving PySide2/6 compatibility.test_sgre.pyto handle deprecation of positional arguments in Python 3.13.test_shotgun.pyto be cross-platform and clarified usage of keyword arguments fordownload_url. [1] [2]Vendored
shotgun_api3Updatesexport_pagemethod.authenticate_human_userto use afinallyblock for restoring config, simplifying error handling._inbound_visitorto usedatetime.datetime.strptime.shotgun.py. [1] [2]General Improvements