Harden installer auth handling for GitHub Packages

README.md

@@ -59,8 +59,10 @@ curl -fsSL https://raw.githubusercontent.com/shpitdev/opencode-sandboxed-ad-hoc-
 
 It will:
 
-- ask for (or reuse) a GitHub token with `read:packages`
+- reuse `gh auth` token when available and auto-attempt `read:packages` scope refresh
+- otherwise prompt for a GitHub token with `read:packages`
 - configure `~/.npmrc` for GitHub Packages
+- skip registry auth setup automatically when installing from a local tarball path
 - install `@shpitdev/opencode-sandboxed-ad-hoc-research` globally
 - launch the guided setup flow for Daytona/model credentials
 

scripts/install-gh-package.sh

@@ -22,6 +22,97 @@ require_command() {
   fi
 }
 
+is_interactive_tty() {
+  [[ -t 0 && -t 1 ]]
+}
+
+is_local_package_ref() {
+  local ref="$1"
+  case "$ref" in
+    ./* | ../* | /* | file:* | *.tgz | *.tar.gz | http://* | https://*)
+      return 0
+      ;;
+  esac
+  return 1
+}
+
+scope_list_contains() {
+  local scope_list="$1"
+  local scope="$2"
+  local normalized=",${scope_list// /},"
+  [[ "$normalized" == *",$scope,"* ]]
+}
+
+has_package_read_scope() {
+  local scope_list="$1"
+  scope_list_contains "$scope_list" "read:packages" ||
+    scope_list_contains "$scope_list" "write:packages" ||
+    scope_list_contains "$scope_list" "delete:packages"
+}
+
+get_gh_token_scopes() {
+  local token="$1"
+  if [[ -z "$token" ]]; then
+    return 0
+  fi
+
+  GH_TOKEN="$token" gh api -i /user 2>/dev/null |
+    tr -d '\r' |
+    awk 'BEGIN { IGNORECASE = 1 } /^x-oauth-scopes:/ { sub(/^[^:]*:[[:space:]]*/, ""); print; exit }'
+}
+
+ensure_gh_token_has_package_scope() {
+  local token="$1"
+  local scopes
+  scopes="$(get_gh_token_scopes "$token")"
+
+  if has_package_read_scope "$scopes"; then
+    printf '%s' "$token"
+    return 0
+  fi
+
+  log "gh auth token is missing read:packages scope."
+  if ! is_interactive_tty; then
+    return 1
+  fi
+
+  log "Attempting gh auth scope refresh (read:packages)..."
+  if ! gh auth refresh -h github.com -s read:packages; then
+    return 1
+  fi
+
+  token="$(gh auth token 2>/dev/null || true)"
+  if [[ -z "$token" ]]; then
+    return 1
+  fi
+
+  scopes="$(get_gh_token_scopes "$token")"
+  if has_package_read_scope "$scopes"; then
+    log "gh auth token refreshed with package scope."
+    printf '%s' "$token"
+    return 0
+  fi
+
+  return 1
+}
+
+install_global_package() {
+  local package_ref="$1"
+  local install_output
+
+  if install_output="$(npm install -g "$package_ref" 2>&1)"; then
+    printf '%s\n' "$install_output"
+    return 0
+  fi
+
+  printf '%s\n' "$install_output" >&2
+  if grep -Eqi "npm\\.pkg\\.github\\.com|permission_denied|e401|e403|read:packages" <<<"$install_output"; then
+    printf '[install] ERROR: GitHub Packages auth failed. Token likely missing read:packages.\n' >&2
+    printf '[install] ERROR: Run: gh auth refresh -h github.com -s read:packages\n' >&2
+  fi
+  return 1
+}
+
 upsert_npmrc_line() {
   local key_prefix="$1"
   local line_value="$2"
@@ -42,6 +133,19 @@ upsert_npmrc_line() {
   fi
 }
 
+remove_npmrc_line() {
+  local key_prefix="$1"
+  if [[ ! -f "$NPMRC_PATH" ]]; then
+    return 0
+  fi
+
+  awk -v key_prefix="$key_prefix" '
+    index($0, key_prefix) == 1 { next }
+    { print }
+  ' "$NPMRC_PATH" >"${NPMRC_PATH}.tmp"
+  mv "${NPMRC_PATH}.tmp" "$NPMRC_PATH"
+}
+
 read_token_interactive() {
   local token=""
   printf 'GitHub token (read:packages): '
@@ -56,37 +160,76 @@ main() {
   local registry_host="${REGISTRY_URL#https://}"
   registry_host="${registry_host#http://}"
   registry_host="${registry_host%%/}"
+  local requires_registry_auth="true"
+  if is_local_package_ref "$PACKAGE_NAME"; then
+    requires_registry_auth="false"
+  fi
 
   local token="${NODE_AUTH_TOKEN:-}"
-  if [[ -z "$token" ]] && command -v gh >/dev/null 2>&1; then
+  local token_source="env"
+  if [[ "$requires_registry_auth" == "true" ]] && [[ -z "$token" ]] && command -v gh >/dev/null 2>&1; then
     if gh auth status >/dev/null 2>&1; then
       token="$(gh auth token 2>/dev/null || true)"
       if [[ -n "$token" ]]; then
-        log "Using token from gh auth session."
+        log "Using token from gh auth session. Checking package scope..."
+        token="$(ensure_gh_token_has_package_scope "$token" || true)"
+        token_source="gh"
       fi
     fi
   fi
 
-  if [[ -z "$token" ]]; then
+  if [[ "$requires_registry_auth" == "true" ]] && [[ -z "$token" ]]; then
+    if ! is_interactive_tty; then
+      fail "No usable token found for GitHub Packages. Set NODE_AUTH_TOKEN with read:packages."
+    fi
     log "A GitHub token with read:packages is required to install from GitHub Packages."
     token="$(read_token_interactive)"
+    token_source="manual"
   fi
 
-  if [[ -z "$token" ]]; then
+  if [[ "$requires_registry_auth" == "true" ]] && [[ -z "$token" ]]; then
     fail "No GitHub token provided."
   fi
 
-  local npmrc_dir
-  npmrc_dir="$(dirname "$NPMRC_PATH")"
-  mkdir -p "$npmrc_dir"
+  if [[ "$requires_registry_auth" == "true" ]]; then
+    local npmrc_dir
+    npmrc_dir="$(dirname "$NPMRC_PATH")"
+    mkdir -p "$npmrc_dir"
 
-  upsert_npmrc_line "${PACKAGE_SCOPE}:registry=" "${PACKAGE_SCOPE}:registry=${REGISTRY_URL}"
-  upsert_npmrc_line "//${registry_host}/:_authToken=" "//${registry_host}/:_authToken=${token}"
-  upsert_npmrc_line "always-auth=" "always-auth=true"
-  log "Updated ${NPMRC_PATH} for ${PACKAGE_SCOPE}."
+    upsert_npmrc_line "${PACKAGE_SCOPE}:registry=" "${PACKAGE_SCOPE}:registry=${REGISTRY_URL}"
+    upsert_npmrc_line "//${registry_host}/:_authToken=" "//${registry_host}/:_authToken=${token}"
+    remove_npmrc_line "always-auth="
+    log "Updated ${NPMRC_PATH} for ${PACKAGE_SCOPE}."
+  else
+    log "Local package reference detected; skipping GitHub Packages auth setup."
+  fi
 
   log "Installing ${PACKAGE_NAME} globally..."
-  npm install -g "$PACKAGE_NAME"
+  if ! install_global_package "$PACKAGE_NAME"; then
+    if [[ "$requires_registry_auth" == "true" ]] &&
+      [[ "$token_source" == "gh" ]] &&
+      command -v gh >/dev/null 2>&1 &&
+      is_interactive_tty; then
+      log "Retrying after gh auth refresh (read:packages)..."
+      if gh auth refresh -h github.com -s read:packages; then
+        token="$(gh auth token 2>/dev/null || true)"
+        if [[ -n "$token" ]]; then
+          upsert_npmrc_line "//${registry_host}/:_authToken=" "//${registry_host}/:_authToken=${token}"
+          if install_global_package "$PACKAGE_NAME"; then
+            log "Install succeeded after token refresh."
+          else
+            fail "Global install failed after token refresh."
+          fi
+        else
+          fail "Global install failed and gh did not return a token after refresh."
+        fi
+      else
+        fail "Global install failed and gh auth refresh was unsuccessful."
+      fi
+    else
+    fail "Global install failed."
+    fi
+  fi
 
   if ! command -v "$SETUP_BIN" >/dev/null 2>&1; then
     fail "Install completed but ${SETUP_BIN} is not in PATH."