Closed
Conversation
jmhain
reviewed
Mar 16, 2026
Comment on lines
+4177
to
+4178
| let tokens = Tokenizer::new(&dialect, "SELECT a <-> b") | ||
| .tokenize() |
Collaborator
There was a problem hiding this comment.
Can you use all_dialects_where(|d| d.supports_geometric_types())? and (I assume) all_dialects() for the case above?
Author
There was a problem hiding this comment.
aargh, PostgreSQL seems to have issues still with <-4000 case and <=-4000. Seems broken in general. I will see if there is a better solution
Author
|
Opened an external PR as it is general bug in the upstream: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dialects that support geometric types (e.g. Redshift), the tokenizer treated < followed by - too eagerly causing it to consume the wrong operator. For example when tokenizing something like
<-4000. I don't think there is an operator for<-and the correct tokenizing there should beLT MINUS 4000.Should I create this fix in upstream first?