Replace union member CSS with any to speed up type checking massively.#1
Replace union member CSS with any to speed up type checking massively.#1DrJKL wants to merge 9 commits intosigmacomputing:canaryfrom
Conversation
| [K: string]: ( | ||
| | number | ||
| | string | ||
| | CSS<Media, Theme, ThemeMap, Utils> |
There was a problem hiding this comment.
Doesn't this mean that we lose type completion on nested css objects/properties?
There was a problem hiding this comment.
Do you have an example where that would apply? I think line 30's member should handle most properties.
There was a problem hiding this comment.
Im talking about the nested case. Line 30 handles properties at the top of the object. I think the line you are removing handles all the nested properties.
|
We should probably adopt the standard publishing practices for open source repos for this repo. Typically you would land a PR that contains changes. Then make a separate PR that updates the package version. And only once that has landed, publish a new version. That way we actually adhere to semver and are not unnecessarily publishing packages with changes that are "in-flight" |
DrJKL
force-pushed
the
drjkl/tippy-tap-im-typing-away
branch
from
5b1b1d2 to
41e14d1
Compare
2 participants
See stitchesjs#1038 (comment)