Remove stateful reconnects for SignalR#3690
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3690 +/- ##
=======================================
Coverage 81.82% 81.82%
=======================================
Files 619 619
Lines 38619 38619
Branches 6317 6293 -24
=======================================
Hits 31601 31601
- Misses 6044 6057 +13
+ Partials 974 961 -13 ☔ View full report in Codecov by Sentry. |
Nateowami
approved these changes
Feb 16, 2026
Collaborator
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables the SignalR stateful reconnection feature.
I have marked this PR as critical path, as the current build on QA requires this PR before it can go to live.
When this feature is enabled, and a large sync is taking place, the sync will effectively be blocked until the message is delivered to the client. If the buffer gets too full (as the client is struggling to keep up), or the client has a connection interruption, syncs will be effectively put on hold until the client resumes listening to the buffer.
For the PR that requires this feature (#3638), I will create a custom notification hub just for the import wizard that uses stateful reconnection (stateful reconnects are configured per notification hub), and keep the primary notification hub (used for syncing and build status) not using stateful reconnection.
This change is