Skip to content

Remove stateful reconnects for SignalR#3690

Merged
Nateowami merged 1 commit intomasterfrom
fix/remove_stateful_reconnects
Feb 16, 2026
Merged

Remove stateful reconnects for SignalR#3690
Nateowami merged 1 commit intomasterfrom
fix/remove_stateful_reconnects

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Feb 16, 2026

This PR disables the SignalR stateful reconnection feature.

I have marked this PR as critical path, as the current build on QA requires this PR before it can go to live.

When this feature is enabled, and a large sync is taking place, the sync will effectively be blocked until the message is delivered to the client. If the buffer gets too full (as the client is struggling to keep up), or the client has a connection interruption, syncs will be effectively put on hold until the client resumes listening to the buffer.

For the PR that requires this feature (#3638), I will create a custom notification hub just for the import wizard that uses stateful reconnection (stateful reconnects are configured per notification hub), and keep the primary notification hub (used for syncing and build status) not using stateful reconnection.


This change is Reviewable

@pmachapman pmachapman added critical path PRs that are on our critical path and need attention to keep things moving. Priority 2nd. testing not required labels Feb 16, 2026
@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.82%. Comparing base (2640199) to head (17c4ee0).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/SIL.XForge.Scripture/Startup.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3690   +/-   ##
=======================================
  Coverage   81.82%   81.82%           
=======================================
  Files         619      619           
  Lines       38619    38619           
  Branches     6317     6293   -24     
=======================================
  Hits        31601    31601           
- Misses       6044     6057   +13     
+ Partials      974      961   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami enabled auto-merge (squash) February 16, 2026 14:32
Copy link
Collaborator

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Nateowami reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman).

@Nateowami Nateowami merged commit 840cc41 into master Feb 16, 2026
32 of 33 checks passed
@Nateowami Nateowami deleted the fix/remove_stateful_reconnects branch February 16, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

critical path PRs that are on our critical path and need attention to keep things moving. Priority 2nd. testing not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants