Skip to content

Keep assignee on onboarding requests even after resolving#3691

Open
Nateowami wants to merge 1 commit intomasterfrom
feature/keep-assignee-resolved-onboarding-requests
Open

Keep assignee on onboarding requests even after resolving#3691
Nateowami wants to merge 1 commit intomasterfrom
feature/keep-assignee-resolved-onboarding-requests

Conversation

@Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Feb 17, 2026

Previously resolving an onboarding request cleared the assignee. It was requested that the assignee stay on the request, so it's possible to look back at requests and see who handled them.

This necessitated two changes:

  1. Stop clearing the assignee when the request is resolved
  2. Update the status calculation to not assume that a request that has an assignee is in progress.

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.82%. Comparing base (840cc41) to head (14ff8ff).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/SIL.XForge.Scripture/Models/OnboardingRequest.cs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3691   +/-   ##
=======================================
  Coverage   81.82%   81.82%           
=======================================
  Files         619      619           
  Lines       38619    38618    -1     
  Branches     6317     6317           
=======================================
  Hits        31601    31601           
+ Misses       6044     6043    -1     
  Partials      974      974           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant