Skip to content

feat: add support for making HTTP requests#5

Merged
jjhafer merged 3 commits into
silvermine:masterfrom
jjhafer:jhafer/implement_http_requests
Mar 16, 2026
Merged

feat: add support for making HTTP requests#5
jjhafer merged 3 commits into
silvermine:masterfrom
jjhafer:jhafer/implement_http_requests

Conversation

@jjhafer
Copy link
Copy Markdown
Contributor

@jjhafer jjhafer commented Mar 13, 2026

Includes the following features:

  • A dynamic 'allowlist' which can be configured at initialization and during an app session.

  • Retry support.

  • See README for more information.

@jjhafer jjhafer requested a review from velocitysystems March 13, 2026 15:47
Comment thread src/client.rs
Comment thread guest-js/types.ts Outdated
Comment thread src/lib.rs
Comment thread src/commands.rs
@jjhafer jjhafer force-pushed the jhafer/implement_http_requests branch 2 times, most recently from dc964bd to 4d20f80 Compare March 13, 2026 17:49
@jjhafer jjhafer requested a review from velocitysystems March 13, 2026 22:35
Comment thread guest-js/headers.ts
Comment thread src/client.rs Outdated
Comment thread src/commands.rs
Comment thread src/commands.rs
@jjhafer jjhafer force-pushed the jhafer/implement_http_requests branch from d5f5bdd to f99e0fd Compare March 16, 2026 11:47
@jjhafer jjhafer requested a review from velocitysystems March 16, 2026 11:55
Comment thread guest-js/http-client.ts
Comment thread guest-js/headers.ts
Comment thread guest-js/http-client.test.ts Outdated
Comment thread guest-js/errors.ts
Comment thread src/commands.rs Outdated
Comment thread examples/tauri-app/src/main.js Outdated
@jjhafer jjhafer force-pushed the jhafer/implement_http_requests branch from f99e0fd to c18fe8e Compare March 16, 2026 13:06
Comment thread src/client.rs Outdated
jjhafer added 2 commits March 16, 2026 10:07
Includes the following features:

* A dynamic 'allowlist' which can be configured at
initialization and during an app session.

* Retry support.

See README for more information.
@jjhafer jjhafer force-pushed the jhafer/implement_http_requests branch from c18fe8e to ca2ca27 Compare March 16, 2026 14:08
Base64-encoding response bodies added ~33% size overhead and unnecessary
CPU work on every response. Binary framing sends raw bytes directly over
IPC, removing that cost while keeping a structured metadata header.

Switch the fetch command from returning a JSON-serialized FetchResponse
to a binary-framed tauri::ipc::Response, eliminating base64 encoding
overhead for response bodies. The frame format is:
[4-byte BE metadata length][metadata JSON][body bytes]
@jjhafer jjhafer force-pushed the jhafer/implement_http_requests branch from ca2ca27 to 3424843 Compare March 16, 2026 14:27
@jjhafer jjhafer requested a review from velocitysystems March 16, 2026 14:28
Copy link
Copy Markdown
Contributor

@velocitysystems velocitysystems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jjhafer - LGTM.

@jjhafer jjhafer merged commit cbdca69 into silvermine:master Mar 16, 2026
1 check passed
jjhafer added a commit that referenced this pull request Mar 16, 2026
feat: add support for making HTTP requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants