Skip to content

Fix snprintf size argument#10

Open
ggalgoczi wants to merge 1 commit intosimoncblyth:masterfrom
ggalgoczi:fix_sdigest_snprintf_size_arg
Open

Fix snprintf size argument#10
ggalgoczi wants to merge 1 commit intosimoncblyth:masterfrom
ggalgoczi:fix_sdigest_snprintf_size_arg

Conversation

@ggalgoczi
Copy link

Fix snprintf size argument in sdigest.h to avoid _FORTIFY_SOURCE abort caused by glibc hardening feature.

Fix snprintf size argument in sdigest.h to avoid _FORTIFY_SOURCE abort caused by glibc hardening feature
@ggalgoczi
Copy link
Author

sdigest::Finalize() and sdigest::DescRaw() call snprintf:

  • Larger size argument is given than the allocated length
  • Never ran over the allocated length so there was no problem due to this ever
  • However eic_cuda container uses _FORTIFY_SOURCE, a compile-time/runtime hardening feature in glibc that aborts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant