fix: Call after_call callback when tool doesn't exist#1373
Open
BillionClaw wants to merge 1 commit intosimonw:mainfrom
Open
fix: Call after_call callback when tool doesn't exist#1373BillionClaw wants to merge 1 commit intosimonw:mainfrom
BillionClaw wants to merge 1 commit intosimonw:mainfrom
Conversation
The --td (tool debug) flag was not showing debug output when a model tried to call a tool that doesn't exist. This happened because the after_call callback was not being invoked in the error case. Changes: - Response.execute_tool_calls(): Call after_call when tool is None - AsyncResponse.execute_tool_calls(): Call after_call when tool is None or has no implementation in both sync and async branches Fixes simonw#1151
|
Friendly bump -- this PR has been open for a while. Happy to make any changes if needed, or close it if no longer relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1151
The --td (tool debug) flag was not showing debug output when a model tried to call a tool that doesn't exist. This happened because the after_call callback was not being invoked when:
Changes:
This ensures that users always see debug output when using --td, even when the model calls a tool incorrectly (e.g., using the wrong tool name).