[Student Assignment] Skip registering OpenAI models when no API key is configured + add test#1456
Open
thetree61 wants to merge 1 commit into
Open
[Student Assignment] Skip registering OpenAI models when no API key is configured + add test#1456thetree61 wants to merge 1 commit into
thetree61 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I am a student. I chose to implement this issue (#1445) as a learning exercise for my open-source contribution course assignment.
Although a similar PR (#1446) exists, I have re-implemented it independently and designed a set of comprehensive unit tests to verify the behavior (which I have included in this PR).
I need to submit the URL of this PR to complete my assignment. Please feel free to close this PR directly as I understand the other PR is already under review. Thank you so much for your understanding and for maintaining such a wonderful project!