Start refactoring model slicer#104
Draft
santisoler wants to merge 1 commit into
Draft
Conversation
The goal is to ditch the `slice_matrix` in `ModelSlice` and stop using sparse diagonal arrays to slice models and construct the expanded matrices. Instead, create a new linear operator for them that stores just a slice object, a shape and an offset. The idea is that sparse diagonal arrays use more memory, and indexing with arrays is less efficient than indexing with slices. There's still work to be done on this, this is just a draft.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to ditch the
slice_matrixinModelSliceand stop using sparse diagonal arrays to slice models and construct the expanded matrices. Instead, create a new linear operator for them that stores just a slice object, a shape and an offset. The idea is that sparse diagonal arrays use more memory, and indexing with arrays is less efficient than indexing with slices.There's still work to be done on this, this is just a draft.