Fix xcancel and bcancel not rendering#128
Open
thomaskrabichler wants to merge 1 commit intosimpleclub:mainfrom
Open
Fix xcancel and bcancel not rendering#128thomaskrabichler wants to merge 1 commit intosimpleclub:mainfrom
thomaskrabichler wants to merge 1 commit intosimpleclub:mainfrom
Conversation
- Fix typo: 'downdiagnoalstrike' -> 'downdiagonalstrike' in enclosure.dart - Fix array syntax: comma was inside string instead of separating elements in enclose.dart
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo bug fixes related to mathematical notation handling in the LaTeX parser: correcting a typo in diagonal strike notation detection and restructuring the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
\xcanceland\bcancelcommands don't render correctly.Cause
Two bugs:
Typo in enclosure.dart (line 98)
'downdiagnoalstrike'should be'downdiagonalstrike'Array syntax in enclose.dart (line 91)
['updiagonalstrike, downdiagonalstrike']- comma is inside the stringShould be:
['updiagonalstrike', 'downdiagonalstrike']- two separate elementsResult
\bcancelnow draws the correct diagonal\xcancelnow draws both diagonals