Skip to content

fix(credential-selector): remove reserved icon space when no credential selected#3348

Merged
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/fix-empty-cred-icon-space
Feb 26, 2026
Merged

fix(credential-selector): remove reserved icon space when no credential selected#3348
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/fix-empty-cred-icon-space

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • Only reserve left padding for the credential icon when the overlay content (icon + label) is actually rendered
  • Previously, padding was reserved based on selectedId which could be truthy without a visible icon

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Feb 26, 2026 6:12am

Request Review

@waleedlatif1 waleedlatif1 force-pushed the waleedlatif1/fix-empty-cred-icon-space branch from 66fe26c to 9b0415d Compare February 26, 2026 06:12
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 26, 2026

Greptile Summary

Fixed visual bug where left padding was reserved for the credential icon even when no credential data was available to display. The padding is now correctly applied only when overlayContent (icon + label) is actually rendered, rather than when selectedId or isCredentialSetSelected is truthy. This prevents awkward spacing in edge cases where a credential ID exists but the credential data hasn't loaded yet or is inaccessible.

  • Changed className condition from selectedId || isCredentialSetSelected to overlayContent on line 382
  • More accurately reflects the actual presence of rendered overlay content
  • Improves visual consistency in loading and error states

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Single-line visual fix with clear intent that better aligns the padding logic with actual rendered content. The change is well-contained, improves UX consistency, and has no impact on functionality or data handling.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/credential-selector/credential-selector.tsx Fixed padding logic to only apply when overlay content (icon + label) is actually rendered, preventing unnecessary spacing when credential data is unavailable

Last reviewed commit: 9b0415d

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@waleedlatif1
Copy link
Collaborator Author

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@waleedlatif1 waleedlatif1 merged commit ba7d6ff into staging Feb 26, 2026
12 checks passed
@waleedlatif1 waleedlatif1 deleted the waleedlatif1/fix-empty-cred-icon-space branch February 26, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant