fix(models): exclude reseller providers from model catalog pages#4117
fix(models): exclude reseller providers from model catalog pages#4117waleedlatif1 merged 2 commits intostagingfrom
Conversation
Reseller providers like OpenRouter, Fireworks, Azure, Vertex, and Bedrock are aggregators that proxy other providers' models. Their model detail pages were generating broken links. Filter them out of MODEL_PROVIDERS_WITH_CATALOGS so they don't generate static pages or appear as clickable entries in the model directory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The Reviewed by Cursor Bugbot for commit 6068fbc. Configure here. |
Greptile SummaryThis PR fixes broken model detail page links on Confidence Score: 5/5Safe to merge — the fix correctly excludes reseller providers from catalog pages and JSON-LD structured data with no functional regressions. The only finding is a P2 messaging inconsistency where TOTAL_MODEL_PROVIDERS still counts reseller providers while TOTAL_MODELS counts only non-reseller models. This does not affect functionality, routing, or data integrity — it is a cosmetic copy/SEO concern that does not block merge. apps/sim/app/(landing)/models/utils.ts — the TOTAL_MODEL_PROVIDERS / TOTAL_MODELS mismatch on lines 563-564. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PROVIDER_DEFINITIONS\nall providers] --> B[rawProviders\nall CatalogProvider objects]
B --> C[MODEL_CATALOG_PROVIDERS\nall providers incl. resellers]
C -->|models.length > 0\n&& !isReseller| D[MODEL_PROVIDERS_WITH_CATALOGS\nnon-reseller providers with models]
C -->|models.length === 0| E[MODEL_PROVIDERS_WITH_DYNAMIC_CATALOGS\nproviders with no static models\nincl. OpenRouter, Fireworks]
D --> F[ALL_CATALOG_MODELS\nnon-reseller models only]
F --> G[TOTAL_MODELS]
C --> H[TOTAL_MODEL_PROVIDERS\ncounts ALL providers incl. resellers]
D --> I[/models directory\nclickable provider + model rows/]
E --> J[/models directory\nDynamic model catalogs section/]
D --> K[JSON-LD ItemList\nvalid product URLs only]
Reviews (2): Last reviewed commit: "fix(models): use filtered catalog for JS..." | Re-trigger Greptile |
Switch flatModels in page.tsx from MODEL_CATALOG_PROVIDERS to MODEL_PROVIDERS_WITH_CATALOGS so the Schema.org ItemList excludes reseller models, matching TOTAL_MODELS and avoiding broken URLs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6068fbc. Configure here.

Summary
MODEL_PROVIDERS_WITH_CATALOGS/modelssince their proxied models don't have valid catalog pagesisResellerflag already set on all aggregator providers — single-line filter additionTest plan
/modelspage loads without broken links