Skip to content

chore(skills): reinforce skills to not guess integration outputs#4122

Merged
icecrasher321 merged 1 commit intostagingfrom
feat/zillow
Apr 12, 2026
Merged

chore(skills): reinforce skills to not guess integration outputs#4122
icecrasher321 merged 1 commit intostagingfrom
feat/zillow

Conversation

@icecrasher321
Copy link
Copy Markdown
Collaborator

Summary

Notice fetch failures leading to model guessing outputs rather than reporting to the user that it can't see the API responses.

Type of Change

  • Other: Skill Improvement

Testing

Tested manually with Zillow [API docs do not reveal API responses since it's a closed API]

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Apr 12, 2026 9:30pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 12, 2026

PR Summary

Low Risk
Low risk documentation/metadata-only changes; main impact is on agent behavior guidance and how integrations are categorized/displayed in the landing UI.

Overview
Hardens multiple Sim agent skills (add/validate tools, blocks, connectors, integrations, triggers) with explicit rules to stop and ask for docs/samples/credentials when response or webhook payload schemas are unknown, rather than guessing outputs or writing unverified transformResponse/mappings.

Separately adjusts presentation data: updates the FireworksIcon fill color, and revises integrations.json ordering/values for integrationTypes and tags across many integrations (including adding/removing categories like developer-tools in several entries).

Reviewed by Cursor Bugbot for commit 25481bb. Configure here.

"category": "tools",
"tags": ["agentic", "automation"],
"integrationTypes": ["developer-tools", "ai"]
"integrationTypes": ["developer-tools", "ai"],
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter just reordered these, no material change

@icecrasher321 icecrasher321 changed the title chore(skills): reinforce skill to not guess integration outputs chore(skills): reinforce skills to not guess integration outputs Apr 12, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 12, 2026

Greptile Summary

This PR adds a "Hard Rule: No Guessed Tool/Response Schemas" section to eight skill instruction files (add-block, add-connector, add-integration, add-tools, add-trigger, validate-connector, validate-integration, validate-trigger) to prevent AI agents from fabricating API output shapes when documentation or live verification is unavailable. It also reorders tags/integrationTypes fields across many entries in integrations.json (putting integrationTypes before tags) and updates a few integrationTypes values, plus changes the FireworksIcon fill from currentColor to a hardcoded hex #5019c5.

Confidence Score: 4/5

Mostly safe to merge; one P1 issue in icons.tsx should be addressed before shipping.

The skill instruction changes are clean and well-structured. The integrations.json reordering is cosmetic. The single concern is the FireworksIcon fill color change from currentColor to a hardcoded hex, which breaks color inheritance for all usages of that icon and is inconsistent with every other icon in the file.

apps/docs/components/icons.tsx — FireworksIcon fill should be reverted to currentColor unless the hardcoded purple is intentional and documented.

Important Files Changed

Filename Overview
.agents/skills/add-block/SKILL.md Adds 'Hard Rule: No Guessed Tool Outputs' section and reinforces it in two additional places — clear and consistent guidance.
.agents/skills/add-connector/SKILL.md Adds 'Hard Rule: No Guessed Response Or Document Schemas' with clear alternatives; consistent with the other skill files.
.agents/skills/add-integration/SKILL.md Adds 'Hard Rule: No Guessed Response Schemas' and two checklist items for verifying response schemas and reporting unknowns.
.agents/skills/add-tools/SKILL.md Adds 'Hard Rule: No Guessed Response Schemas' with alternatives and reinforces it at the end of the outputs section and validation checklist.
.agents/skills/add-trigger/SKILL.md Adds 'Hard Rule: No Guessed Webhook Payload Schemas' with alternatives for unknown payload shapes.
.agents/skills/validate-connector/SKILL.md Adds 'Hard Rule: No Guessed Source Schemas' in the API doc fetching step and appends checklist items for verified field extraction and reporting unknowns.
.agents/skills/validate-integration/SKILL.md Adds 'Hard Rule: No Guessed Response Schemas' in the validate step and checklist items for verified field extraction and reporting unknowns.
.agents/skills/validate-trigger/SKILL.md Adds 'Hard Rule: No Guessed Webhook Payload Schemas' in the validate step and checklist items for verified payload field mapping and reporting unknowns.
apps/docs/components/icons.tsx Changes FireworksIcon fill from currentColor to hardcoded #5019c5, breaking theme/color inheritance.
apps/sim/app/(landing)/integrations/data/integrations.json Reorders tags/integrationTypes fields (putting integrationTypes first) across many entries and updates some integrationTypes values; purely data changes with no logic impact.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Skill invoked: add-tools / add-block / add-integration\nadd-connector / add-trigger\nvalidate-*] --> B{API docs available?}
    B -- Yes --> C[Implement tool/block/trigger\nusing documented response schema]
    B -- No --> D{Hard Rule triggered}
    D --> E[Ask user for sample responses]
    D --> F[Ask user for test credentials]
    D --> G[Scope to documented endpoints only]
    D --> H[Leave unimplemented, report unknown fields]
    C --> I[Validation checklist:\nEvery output/field backed by\ndocs or live-verified payloads]
    I --> J{Unknown schemas remain?}
    J -- Yes --> K[Report to user, do NOT guess]
    J -- No --> L[Submit implementation]
Loading

Comments Outside Diff (1)

  1. apps/docs/components/icons.tsx, line 321 (link)

    P1 Hardcoded color breaks theme inheritance

    Changing fill='currentColor' to fill='#5019c5' means the icon will always render in this specific purple regardless of the surrounding text color or theme context. Every other icon in this file uses currentColor to inherit color from CSS, so this icon will stand out unexpectedly in any context where the parent color differs (dark mode, hover states, different backgrounds). Was this intentional, or should it remain currentColor like the rest?

Reviews (1): Last reviewed commit: "chore(skills): reinforce skill to not gu..." | Re-trigger Greptile

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 25481bb. Configure here.

@icecrasher321 icecrasher321 merged commit 6d2deb1 into staging Apr 12, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant