Conversation
| raw=False, | ||
| samples=1, | ||
| padding=0, | ||
| multivariate_allowed_symbols = [], |
There was a problem hiding this comment.
add multivariate_allowed_symbols to the docstrings above
| @@ -0,0 +1,72 @@ | |||
| from .multivariate_formatting import MultivariateFormattingMethod | |||
There was a problem hiding this comment.
we rely on absolute imports rather than relative in our packaging:
| from .multivariate_formatting import MultivariateFormattingMethod | |
| from sigllm.primitives.formatting.multivariate_formatting import MultivariateFormattingMethod |
| from .multivariate_formatting import MultivariateFormattingMethod | ||
| import numpy as np |
There was a problem hiding this comment.
typically we follow the following structure for imports:
# python inherent libraries (e.g. import os)
# 3rd party libraries (e.g. import numpy)
# this library (e.g. import sigllm)this is google python style coding, so in your case it will be:
import numpy as np
from sigllm.primitives.formatting.multivariate_formatting import MultivariateFormattingMethod| if __name__ == "__main__": | ||
| method = DigitInterleave(digits_per_timestamp=3) | ||
| method.test_multivariate_formatting_validity(verbose=False) | ||
| errs, y_hat, y = method.run_pipeline(return_y_hat=True) | ||
| print(errs) | ||
| print(y_hat) | ||
| print(y) No newline at end of file |
There was a problem hiding this comment.
after you finish testing, this can be removed.
| }) | ||
|
|
||
|
|
||
| def run_pipeline(self, data=create_test_data(), |
There was a problem hiding this comment.
what's the purpose of this method? It can be removed or moved to utils since it doesn't belong in formatting
There was a problem hiding this comment.
can you remove this file from the PR? I don't think it's related.
There was a problem hiding this comment.
rename it to multivariate-detector-pipeline
There was a problem hiding this comment.
Can you make it an end-to-end tutorial of using the pipeline? In addition to the new formatting, you can have a full detection process and show the anomalies.
2 participants
Resolve #57
Added a multivariate detector pipeline with various formatting methods.