Conversation
- Use comma-separated format for tools and allowed-tools fields
(e.g., `tools: Read, Write, Grep` not `tools: ["Read", "Write"]`)
- Fix code fence nesting in complete-agent-examples.md
- Add "Fields NOT Available for Agents" section clarifying skill-only
fields (context: fork, user-invocable, disable-model-invocation)
- Add portable paths note about ${CLAUDE_PLUGIN_ROOT} for agents
- Remove YAML array format examples from frontmatter-reference.md
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove redundant content to bring word count from 2,409 to 2,199: - Condense System Prompt Design section (detailed templates in references/) - Remove Implementation Workflow (duplicates Creating Agents) - Remove Minimal Agent from Quick Reference (duplicates Quick Start) - Remove duplicate skill cross-references (covered in See also block) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add .lsp.json separate file configuration option - Document 8 missing optional fields (transport, initializationOptions, settings, workspaceFolder, startupTimeout, shutdownTimeout, restartOnCrash, maxRestarts) - Add "What Claude Gains from LSP" section - Update pre-built plugins table with 11 languages - Create references/lsp-capabilities.md (was referenced but missing) - Add examples/minimal-lsp-plugin/ with complete Go LSP plugin - Add examples/lsp-json-configs.md with 10 configuration patterns Word count: 961 → 1,284 (now within 1,000-2,200 target) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update docs/ci-cd.md to reflect current workflows (add yaml-lint.yml, remove weekly-maintenance.yml which no longer exists) - Apply prettier formatting to 4 skill files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Claude finished @sjnims's task in 1m 18s —— View job PR Review: v0.3.2 Release Preparation
Verdict:
|
| Check | Result |
|---|---|
| markdownlint | ✅ Pass (0 errors) |
| prettier | ✅ Pass (all files formatted) |
| shellcheck | ⏭️ Skipped (no shell scripts changed) |
Issues Found
2 inline comments posted for corrupted tool patterns in plugins/plugin-dev/skills/mcp-integration/SKILL.md:
- Line 379:
allowed-toolsvalue has**instead of__(markdown bold corruption) - Lines 455-457: Same issue with tool patterns in security best practices section
The double underscores in MCP tool names like mcp__plugin_name_server__create_item were incorrectly converted to markdown bold syntax (mcp**plugin_name_server**create_item), which will break tool matching.
What's Good
- Version consistency: All version references correctly updated to 0.3.2 across
plugin.json,marketplace.json,CLAUDE.md, andCHANGELOG.md - LSP integration improvements: Good additions including separate
.lsp.jsonfile configuration, pre-built plugins table, and new reference/example files - Agent-development optimization: Reduced SKILL.md size while adding useful content (portable paths section, fields not available for agents table)
allowed-toolsformat alignment: Correctly updated from YAML arrays to comma-separated strings matching official Claude Code docs- CHANGELOG entries: Clear, well-structured release notes
- CI/CD docs fix: Correctly removed non-existent
weekly-maintenance.ymland addedyaml-lint.yml
Suggestions
- After fixing the inline comment issues, consider doing a global search for
mcp**to ensure no other instances were corrupted - The new LSP examples are comprehensive and well-documented
claude
bot
added
chore
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Prettier was converting `__` to `**` in MCP tool names like `mcp__plugin_name__tool`, treating double underscores as emphasis. - Restore correct `mcp__` patterns in SKILL.md and tool-usage.md - Add .prettierignore to exclude these files from prettier formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Claude finished @sjnims's task in 2m 9s —— View job PR Review: v0.3.2 Release Preparation (Re-sync)
Verdict:
|
| Check | Result |
|---|---|
| markdownlint | ⏭️ Skipped (tools not globally available) |
| prettier | ⏭️ Skipped (tools not globally available) |
| shellcheck | ⏭️ Skipped (no shell scripts changed) |
Issues Found
1 inline comment posted for broken MCP tool patterns in plugins/plugin-dev/skills/mcp-integration/references/tool-usage.md.
The fix commit (41da12b) correctly restored patterns in SKILL.md, but tool-usage.md has 19 occurrences of malformed patterns like mcp__\1__asana_create_task where \1 is a regex backreference that should be the actual server name (e.g., plugin_asana_asana).
Affected lines: 63, 101, 115, 139, 142, 167, 179-181, 194, 206, 331, 344, 353, 367-369, 384, 510
What's Good
- Version consistency: All version references correctly updated to 0.3.2
- SKILL.md fix: MCP tool patterns properly restored with correct double underscores
- .prettierignore added: Good preventive measure to stop prettier from corrupting
__patterns in the future - CHANGELOG updated: Documents the fix and includes all changes
- LSP integration improvements: Comprehensive additions including pre-built plugins table,
.lsp.jsonconfiguration, and new examples - Agent-development optimization: Trimmed content while adding useful material (portable paths, fields not available for agents)
allowed-toolsformat alignment: Updated from YAML arrays to comma-separated strings per official docs
Recommended Fix
The tool-usage.md file needs the \1 patterns replaced with proper server names. The pattern is:
| Broken | Should Be |
|---|---|
mcp__\1__asana_* |
mcp__plugin_asana_asana__asana_* |
mcp__\1__search |
mcp__plugin_api_server__search (or similar) |
mcp__\1__create_item |
mcp__plugin_api_server__create_item |
mcp__\1__get_project |
mcp__plugin_api_server__get_project |
plugins/plugin-dev/skills/mcp-integration/references/tool-usage.md
Outdated
Show resolved
Hide resolved
Previous sed command left \1 regex remnants. Restored from main and applied clean perl replacement for mcp__*__ patterns. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Claude finished @sjnims's task in 2m 8s —— View job PR Review: v0.3.2 Release Preparation (Re-review)
Verdict: ✅ Looks GoodQuality Checks
Note: The linting tools (markdownlint-cli2, prettier) are not globally available in this CI environment. However, the PR description indicates these checks pass locally. Issues from Previous Reviews - All Fixed ✅
All 19 occurrences of malformed MCP tool patterns in What's GoodVersion Consistency ✅
MCP Pattern Fix ✅
LSP Integration Improvements ✅
Agent Development Optimization ✅
Documentation Updates ✅
No Issues FoundThe fix commits have resolved all previously identified issues. The PR is ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version bump to v0.3.2 - documentation improvements release.
Changes
Checklist
🤖 Generated with Claude Code