WIP: 68 sdc lock node image version#189
Conversation
Upgrade with upstream
Better have it as a separate github project
Not sure what use case this script is the answer to. Today raw node image is used with no script attached I believe. Can you please detail your thoughts ? |
|
For point 1: Sure. We could have a repo for that purpose. As I understand, this MR is to explain/expose some ideas. For point 2: That script basically does same as defined into the Makefile rules, defined for each project. This way, by just mounthing theme as volume at "/frontend/themes", then no need to have same rules on each project's Makefile. Basically executing simpler commands like In the other side of the coin, there is around there (looks like https://projects.skilld.cloud/skilld/ski-contrib/issues/9) a task to define theme path. With this script, that's not needed anymore, because it could do it for all themes in a single-shoot. |
|
I'm currently working on PR skilld-labs/docker-frontend#26 to create a new docker image for kaizen |
andypost
left a comment
andypost
left a comment
There was a problem hiding this comment.
This pr doing custom image in wrong way for no reason, lts is moving for node and you adds complexity/security issue in build process - please elaborate reasons!
| @@ -0,0 +1,9 @@ | |||
| FROM node:lts-alpine3.10 | |||
There was a problem hiding this comment.
Don't use outdated alpine
There was a problem hiding this comment.
If you're making custom image you need a way to push/pull it
There was a problem hiding this comment.
Lts version just changed and all builds are broken
There was a problem hiding this comment.
I prefer to move with skilld-labs/docker-frontend#26 cos themes are all separate and they must manage its dependencies out of sdc
There was a problem hiding this comment.
agreed, it's a dependency that is dependent solely on our theme(s) after fall
|
@waspper still not sure we should ship the docker image with project |
4 participants
This is a concept/idea for #179.