Skip to content

Log a message when navigation is throttled#373

Merged
marcprux merged 1 commit intoskiptools:mainfrom
dfabulich:log-navigation-throttle
Mar 31, 2026
Merged

Log a message when navigation is throttled#373
marcprux merged 1 commit intoskiptools:mainfrom
dfabulich:log-navigation-throttle

Conversation

@dfabulich
Copy link
Copy Markdown
Contributor

This bit me hard when I was trying to write automated tests against the Showcase… took me a loooong time to track down. A little bit of logging would have gone a long way to help me figure it out!

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device
  • REQUIRED: I have checked whether this change requires a corresponding update in the Skip Fuse UI repository (link related PR if applicable)
  • OPTIONAL: I have added an example of any UI changes in the Showcase sample app

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

@cla-bot cla-bot bot added the cla-signed label Mar 31, 2026
@marcprux
Copy link
Copy Markdown
Member

Seems useful.

Even more useful would be to get rid of the need to perform the throttling (which was added in a11d2f5), if we can find some alternative solution. Perhaps Navigation 3 (#292) would obviate the hack?

@dfabulich
Copy link
Copy Markdown
Contributor Author

I filed #376 to get rid of navigation throttling.

@dfabulich dfabulich requested a review from marcprux March 31, 2026 17:34
@marcprux marcprux merged commit 9bd3392 into skiptools:main Mar 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants