Warn when skip doctor/skip checkup can't find any attached devices#196
Warn when skip doctor/skip checkup can't find any attached devices#196dfabulich wants to merge 4 commits intoskiptools:mainfrom
skip doctor/skip checkup can't find any attached devices#196Conversation
marcprux
left a comment
There was a problem hiding this comment.
This skip doctor command is meant to check if the system prerequisites are satisfied for Skip, not necessarily that it is "ready to go". It is used, e.g., as the first step in CI workflows to make sure that everything is in order.
That being said, I do think that this could be a valuable addition. Could we gate this check behind a "--preflight" flag?
|
I think instead of an opt-in IMO, the core problem is newbies coming to us saying "Hey, uh, I tried Skip, but it's not working," without specifying exactly how it's "not working." So we want to be able to give them a really specific instruction, easy to follow: "Please run Today, We especially don't want newbies to have to separately opt-in to giving us the information we need. (Since they're newbies, they're not going to know about optional CLI arguments.) If they run If anyone should jump through extra hoops, it's CI, which is running code anyway. CI can run |
9873960 to
d318e76
Compare
Fixes #186
skip doctorwarns if it can't find devicesIf
skip doctordoesn't detect any attached Android devices, it will log a warning, like this:Otherwise, it will log how many devices it detected:
skip initcan now install to an emulatorskip inithas a new argument,--launch-android, which will attempt to launch the app on an emulator. I don't expect regular users will want to use it much, but I needed it forskip checkupskip checkupwill attempt to launch if it detects devicesWhen
skip checkupruns thedoctorcommand, it will return a boolean, saying whether it detected any devices. If it did detect devices,skip checkupwill passlaunchAndroid: truetoinitSkipProject. This will install and launch the app on an attached device.If
doctordetected no devices,checkupwill passlaunchAndroid: false. The conclusion will be successful with 1 warning.Skip Pull Request Checklist:
swift testI mostly used Cursor to generate this code. I reviewed every line and tested it manually:
skip doctorwith/without a running emulatorskip checkupwith/without a running emulator