FIX: Add message for single column in associations tab#1758
FIX: Add message for single column in associations tab#1758mithilP007 wants to merge 3 commits intoskrub-data:mainfrom
Conversation
Fixes skrub-data#1747 Adds a conditional check to display a clear message when there is only one column in the dataframe, instead of showing the misleading "No strong associations" message. The new message: "No associations computed because there is only one column."
|
The test failure on The error shows a network timeout while fetching dependencies: This is a transient issue with accessing |
I restarted the jobs, everything seems to be working now |
|
Hi @mithilP007, thanks for the PR. Could you please add a small test in We can merge it after the test is added. |
Removed # noqa: F401 lint suppression comments from the else block (sklearn >= 1.5) to maintain consistency with the if block (sklearn < 1.5) where these comments were already removed. This addresses the code review feedback from coderabbital bot.
|
Hi @mithilP007 :)! You can do |
|
Thanks for the comment @MarieSacksick, you're completely right. I must have lost track of this PR. @mithilP007 as Marie mentioned, the latest commit is not useful for the PR, so it should be reverted. Do you need help with the test? |
|
Hi @mithilP007, are you still working on this PR? |
Fixes #1747
Adds a conditional check to display a clear message when there is only one column in the dataframe, instead of showing the misleading "No strong associations" message.
The new message: "No associations computed because there is only one column."