Draft
Conversation
Member
|
Thank you very much for working on this @sandrineh ! The change looks great; I think the only part left will be removing the "with pytest.warns ..." checks in this test (just removing the context managers, but still keeping the statements that are in those blocks) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the conversation about the issue, I propose to delete the warning message in the file called "-check_input".
This message brings confusion regarding the use of array for the tabular_pipeline function, whereas the conversion of the array to dataframe is carried out later in the code and does not prevent the code from executing correctly overall.