updated how custom filters are implemented for the Table Report#1976
Merged
lisaleemcb merged 6 commits intoskrub-data:mainfrom Mar 24, 2026
Merged
updated how custom filters are implemented for the Table Report#1976lisaleemcb merged 6 commits intoskrub-data:mainfrom
lisaleemcb merged 6 commits intoskrub-data:mainfrom
Conversation
rcap107
approved these changes
Mar 24, 2026
Member
rcap107
left a comment
There was a problem hiding this comment.
Looks good to me, thanks a lot @lisaleemcb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, the
custom_filterskwarg passed to theTableReportrequired a nested dict such asCUSTOM_FILTERS = {'FILTER ID': {filter1: [0,1,2]}}.
Additionally, the only custom filter type that could be passed was a list of ints, indicating the indices of the desired columns.
My proposed change is to
a) streamline the user input such that only one dictionary is required, for example,
CUSTOM_FILTERS = {filter1: selector}and
b) changed the required input to be a skrub Selector object.
Addresses #1969
TBC
How Has This Been Tested?