add system sites e2e tests#2429
Conversation
fgiorgetti
left a comment
fgiorgetti
left a comment
There was a problem hiding this comment.
It is working fine. I have added a couple of comments related to the image option for some of the module invocations, but I believe we should raise a separate issue to handle that, as it seems to affect all e2e tests.
| skupper.v2.controller: | ||
| action: install | ||
| platform: "{{ platform }}" | ||
| failed_when: false |
There was a problem hiding this comment.
I believe that failed_when should be removed here.
If the system-controller is already installed, the module will return OK, not changed.
| ansible.builtin.shell: | ||
| cmd: "{{ platform }} run --name frontend -d --rm -p 127.0.0.1:7070:8080 quay.io/skupper/hello-world-frontend --backend http://host.containers.internal:8080" | ||
| changed_when: false | ||
| when: "'west' in inventory_hostname" |
There was a problem hiding this comment.
Is the when clause needed in these 2 tasks? Considering it is already defined for the block?
| path: "{{ playbook_dir }}/resources/east/" | ||
| platform: "{{ platform }}" | ||
| namespace: "{{ namespace_name }}" | ||
| when: "'east' in inventory_hostname" |
There was a problem hiding this comment.
Same comment for the when clause here, maybe not needed.
|
|
||
| - name: "[ {{ test_identifier }} ] - Start west namespace" | ||
| skupper.v2.system: | ||
| action: start |
There was a problem hiding this comment.
The image option should be passed here (CLI image), using the one built by the CI.
| block: | ||
| - name: "[ {{ test_identifier }} ] - Install system controller" | ||
| skupper.v2.controller: | ||
| action: install |
There was a problem hiding this comment.
The image option should be passed here, using the one built through the CI.
|
|
||
| - name: "[ {{ test_identifier }} ] - Start east namespace" | ||
| skupper.v2.system: | ||
| action: start |
There was a problem hiding this comment.
Same thing here. Pass the image option to the system module.
|
|
||
| - name: "[ {{ test_identifier }} ] - Stop namespaces" | ||
| skupper.v2.system: | ||
| action: stop |
There was a problem hiding this comment.
Pass the image option here (using the CLI image built through the CI).
2 participants
e2e tests that implement the Hello World example in system sites (with manual reload).