Removal of skx-prototype implementation and cleanup of the sync functionality.#105
Draft
ted-ross wants to merge 1 commit into
Draft
Removal of skx-prototype implementation and cleanup of the sync functionality.#105ted-ross wants to merge 1 commit into
ted-ross wants to merge 1 commit into
Conversation
ted-ross
commented
May 13, 2026
| #### Sync Payload | ||
|
|
||
| Record key: | ||
| - `tls-site-<site-id>` |
Member
Author
There was a problem hiding this comment.
Since there is, by definition, only one local site-id per site-controller, should this key simply be tls-site without the site-id appended?
Member
There was a problem hiding this comment.
If removing the site-id from the value simplifies it, fine.
But I don't mind keeping it either.
By the way, would the secret name change as well?
Member
Author
There was a problem hiding this comment.
Let's leave it the way it is.
fgiorgetti
approved these changes
May 14, 2026
| #### Sync Payload | ||
|
|
||
| Record key: | ||
| - `tls-site-<site-id>` |
Member
There was a problem hiding this comment.
If removing the site-id from the value simplifies it, fine.
But I don't mind keeping it either.
By the way, would the secret name change as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is an update to
doc/notes/objects.mdwhich documents the content transferred via the sync protocol.